Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midas NX execute actions #395

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

EmmaSander
Copy link
Contributor

@EmmaSander EmmaSander commented Feb 11, 2025

NOTE: Depends on

Issues addressed by this PR

Start of adding support for the new Midas API.

Part of #394

This adds support for the execute actions Open, New, Save, Save As and Analyse as well as sets up the base support for future API developments.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/MidasCivil_Toolkit/%23395-Midas-NX-excecute-actions?csf=1&web=1&e=dSKGBW

Changelog

Additional comments

Adding in the versioning if/else statements makes the changes appear bigger than they are, everything related to the old versions is largely unchanged.

@EmmaSander EmmaSander changed the title #394 Midas NX execute actions Midas NX execute actions Feb 11, 2025
@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 11, 2025
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, can you fix the compliance failures too please.

@peterjamesnugent
Copy link
Member

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 14, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 21 requests in the queue ahead of you.

@EmmaSander
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 14, 2025

@EmmaSander to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@EmmaSander
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 14, 2025

@EmmaSander to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants