Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 elasticity for new interface 1 #46

Merged
merged 21 commits into from
Mar 22, 2024
Merged

Conversation

srosenbu
Copy link
Member

@srosenbu srosenbu commented Mar 20, 2024

resolves #37 , resolves #33

This PR also introduces handling of history variables, but this is not tested yet. Use with caution

Todo

  • test for uniaxial strain
  • test for plane strain
  • test for plane stress
  • test for full 3D
  • docstrings

Edit: I added the examples directory to the pytest configuration, therefore tests for constitutive models can go into their respective directory, instead of the tests directory of the package itself

@srosenbu srosenbu requested review from pdiercks and saifr68 March 20, 2024 12:31
@srosenbu
Copy link
Member Author

@saifr68 , @pdiercks , I think the PR is ready for review. I still need to add some docstrings and the tests are currently only some sanity checks, but they all pass. The larger test problems whcih were suggested to me can come later as an exampe for the documentation.

@saifr68 saifr68 marked this pull request as ready for review March 21, 2024 11:09
Copy link
Collaborator

@pdiercks pdiercks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srosenbu ,
I have mostly minor suggestions and questions.
I like what you did here, nice work !!

src/fenics_constitutive/solver.py Show resolved Hide resolved
src/fenics_constitutive/solver.py Show resolved Hide resolved
src/fenics_constitutive/solver.py Outdated Show resolved Hide resolved
src/fenics_constitutive/solver.py Show resolved Hide resolved
@srosenbu srosenbu merged commit 664f576 into main Mar 22, 2024
2 checks passed
@srosenbu srosenbu deleted the 33-elasticity-for-new-interface-1 branch March 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants