Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing release #73

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Fixing release #73

merged 4 commits into from
Feb 5, 2025

Conversation

JosePizarro3
Copy link
Contributor

@JosePizarro3 JosePizarro3 commented Feb 5, 2025

This pull request includes several changes to the bam-masterdata repository to improve installation instructions and enhance the CLI functionality. The most important changes include updating the README.md file with installation instructions, refactoring the DATAMODEL_DIR initialization, and modifying the export_to_excel function to dynamically find the definitions.py path.

Documentation updates:

  • README.md: Added installation instructions for the bam-masterdata package and optional [dev] dependencies for CLI functionalities.

Codebase enhancements:

  • bam_masterdata/cli/cli.py: Refactored DATAMODEL_DIR initialization by creating a find_datamodel_dir function to search for the datamodel/ directory in multiple possible locations.
  • bam_masterdata/cli/cli.py: Updated the export_to_excel function to dynamically find the definitions.py path using Path objects, ensuring compatibility with different running environments.

Added functionality for DATAMODEL_DIR being dynamically obtained (either in bam_masterdata or in external folder
@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13155483136

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 96.158%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bam_masterdata/cli/cli.py 6 9 66.67%
Totals Coverage Status
Change from base Build 13138890013: -0.01%
Covered Lines: 16417
Relevant Lines: 17073

💛 - Coveralls

@JosePizarro3 JosePizarro3 merged commit 4e0ec06 into main Feb 5, 2025
8 checks passed
@JosePizarro3 JosePizarro3 deleted the fixing_release branch February 5, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants