Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize Frustum #1

Open
wants to merge 3 commits into
base: gz-rendering9
Choose a base branch
from
Open

Visualize Frustum #1

wants to merge 3 commits into from

Conversation

BA-Utkarsh
Copy link
Owner

@BA-Utkarsh BA-Utkarsh commented Nov 21, 2024

🎉 New feature

Summary

  • Gazebo classic was having visualization of frustum.
  • However, gazebo-garden onwards this plugin is not present.
  • Tested with gazebo-harmonic and gazebo-ionic as well.

Test it

$ . install/setup.sh
$ gz sim examples/worlds/visualize_frustum.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@kazufumi-oyama
Copy link
Collaborator

@BA-Utkarsh
LGTM

@BA-Utkarsh BA-Utkarsh self-assigned this Nov 25, 2024
@BA-Utkarsh
Copy link
Owner Author

BA-Utkarsh commented Nov 25, 2024

@kazufumi-oyama -san, I'm not sure why I'm bot able to assign you as a reviewer. Requesting you to please re-assign on your name.
May be some permission issue..

@BA-Utkarsh
Copy link
Owner Author

@kazufumi-oyama -san, I'm not sure why I'm bot able to assign you as a reviewer. Requesting you to please re-assign on your name. May be some permission issue..

Sent you invite as a collaborator.

@kazufumi-oyama
Copy link
Collaborator

@kazufumi-oyama -san, I'm not sure why I'm bot able to assign you as a reviewer. Requesting you to please re-assign on your name. May be some permission issue..

Sent you invite as a collaborator.

Thank you.

Copy link
Collaborator

@kazufumi-oyama kazufumi-oyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Utkarsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants