Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientCredential and OBO acquireToken requests with claims will now skip the cache #6999

Merged
merged 20 commits into from
Apr 30, 2024
Merged

ClientCredential and OBO acquireToken requests with claims will now skip the cache #6999

merged 20 commits into from
Apr 30, 2024

Conversation

Robbie-Microsoft
Copy link
Collaborator

@Robbie-Microsoft Robbie-Microsoft commented Apr 3, 2024 •
edited
Loading

ClientCredential and OBO acquireToken requests with claims will now skip the cache.

claimsBasedCachingEnabled has been marked as deprecated in msal-node.

@github-actions github-actions bot added msal-node Related to msal-node package msal-common Related to msal-common package labels Apr 3, 2024
@Robbie-Microsoft Robbie-Microsoft linked an issue Apr 3, 2024 that may be closed by this pull request
Claims don't bypass the cache for OBO and client_credentials #6173
Closed
@Robbie-Microsoft Robbie-Microsoft changed the title Claims are now taken into consideration when checking the cache for ClientCredential and OBO Clients Claims are now taken into consideration when checking the cache via a ClientCredential and OBO acquireToken request Apr 3, 2024
@Robbie-Microsoft Robbie-Microsoft changed the title Claims are now taken into consideration when checking the cache via a ClientCredential and OBO acquireToken request ClientCredential and OBO acquireToken requests with claims will now skip the cache Apr 10, 2024
@github-actions github-actions bot removed the msal-common Related to msal-common package label Apr 11, 2024
@Robbie-Microsoft Robbie-Microsoft marked this pull request as draft April 11, 2024 05:41
@Robbie-Microsoft Robbie-Microsoft marked this pull request as ready for review April 11, 2024 17:09
@github-actions github-actions bot added the msal-common Related to msal-common package label Apr 11, 2024
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Apr 29, 2024
sameerag
sameerag requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this as a warning than throw - to not make this breaking for 3.x

@github-actions github-actions bot removed msal-browser Related to msal-browser package msal-common Related to msal-common package labels Apr 30, 2024
@Robbie-Microsoft Robbie-Microsoft merged commit 37633b4 into dev Apr 30, 2024
38 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the claims_bugfix branch April 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-bhargava neha-bhargava neha-bhargava approved these changes

@sameerag sameerag sameerag approved these changes

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@trwalke trwalke Awaiting requested review from trwalke

@pmaytak pmaytak Awaiting requested review from pmaytak

@gladjohn gladjohn Awaiting requested review from gladjohn

@rayluo rayluo Awaiting requested review from rayluo

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft

Assignees
No one assigned
Labels
msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Claims don't bypass the cache for OBO and client_credentials
4 participants
@Robbie-Microsoft @bgavrilMS @sameerag @neha-bhargava