Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RT expiration check #6703

Merged
merged 17 commits into from
Dec 6, 2023
Merged

Add RT expiration check #6703

merged 17 commits into from
Dec 6, 2023

Conversation

tnorling
Copy link
Collaborator

Adds an RT expiration check when available - this is an optimization which avoids a wasted network call when the cached RT is expired. Only applicable to SPA apps using msal-browser

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Merging #6703 (79bfc63) into dev (81d34b4) will decrease coverage by 3.68%.
Report is 399 commits behind head on dev.
The diff coverage is 62.59%.

Additional details and impacted files
Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 79.19% <ø> (-7.28%) ⬇️
msal-common 84.67% <ø> (+0.13%) ⬆️
msal-core ?
msal-node 80.68% <ø> (-2.71%) ⬇️
msal-node-extensions 69.16% <62.08%> (-6.48%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
... and 66 more

... and 187 files with indirect coverage changes

Base automatically changed from export-AAD-params to dev November 17, 2023 20:41
@github-actions github-actions bot added the documentation Related to documentation. label Dec 5, 2023
@tnorling tnorling merged commit 4ef12a5 into dev Dec 6, 2023
56 checks passed
@tnorling tnorling deleted the rt_expires_in branch December 6, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants