Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default iframe timout to 10s #6700

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

hectormmg
Copy link
Member

This PR increases the default iframe timeout to 10s

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Merging #6700 (7372cfe) into dev (81d34b4) will decrease coverage by 4.04%.
Report is 392 commits behind head on dev.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 79.21% <ø> (-7.26%) ⬇️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 41.17% <ø> (-2.58%) ⬇️
... and 51 more

... and 184 files with indirect coverage changes

@hectormmg hectormmg enabled auto-merge (squash) November 15, 2023 19:11
auto-merge was automatically disabled November 15, 2023 19:14

Base branch requires signed commits

@hectormmg hectormmg merged commit aa5296d into dev Nov 16, 2023
30 of 31 checks passed
@hectormmg hectormmg deleted the increase-iframe-timeout branch November 16, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants