Add express session maxAge #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz and
Robbie-Microsoft
as code owners
github-actions
bot
added
the
samples
bgavrilMS
commented
Oct 10, 2023
| @@ -6,27 +6,34 @@ | |||
| import fs from "fs"; | |||
There was a problem hiding this comment.
Only actual change is at line 81, the rest is linting.
bgavrilMS
force-pushed
the
bogavril/express
branch
from
f55db4a to
124de81
Compare
bgavrilMS
force-pushed
the
bogavril/express
branch
from
124de81 to
cfc2b66
Compare
|
@Robbie-Microsoft - please review this. |
bgavrilMS
force-pushed
the
bogavril/express
branch
from
cfc2b66 to
3d6ce1e
Compare
Robbie-Microsoft
approved these changes
Oct 19, 2023
|
@trwalke - can you please have a quick look at this? |
|
@pmaytak - can I please get a PR review for this? |
sameerag
approved these changes
Oct 20, 2023
bgavrilMS
force-pushed
the
bogavril/express
branch
from
3d6ce1e to
65b8545
Compare
pmaytak
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to force AAD to re-evaluate the user access, since the cache storage is done on a per user basis, i.e. shared by several sessions that the user could open.