Rename AndroidActivityInteractiveTokenCommandParameters #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
mohitc1
changed the title
somalaya
approved these changes
Jan 27, 2025
shahzaibj
approved these changes
Jan 28, 2025
mohitc1
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Jan 29, 2025
#2573) Fixes [AB#3100603](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3100603) The PR adds to allow passing google id token credential from app side (in OneAuth) to Android Broker via Android Common. OneAuth can get the id token by using Sign In With Google component added earlier and pass it to Android Broker via BrokerRequest object. Changes include: 1. Make SignInWithGoogleCredential object serializable to allow passing the object from app side to broker as part of BrokerRequest. 2. Locally the reference to object can be maintained in Android AndroidInteractiveTokenCommandParameters which is renamed from AndroidActivityInteractiveTokenCommandParameters to be more flexible to accommodate more fields. 3. On Broker received, BrokerRequest is deserialized. If it has google credentials, it will be attached in BrokerInteractiveTokenCommandParameters as headers (x-ms-fidp-token: <itoken calue>) and extra query parameters (id_provder=google.com). Refer Broker PR. 4. Updated latest broker version to 17. OneAuth should call broker for sign in with google flow only if the broker version supports this version. OneAuth does broker version check early in deciding if support broker is present or not. 5. Added Unit tests. Related PRs: Broker: AzureAD/ad-accounts-for-android#3038 MSAL: AzureAD/microsoft-authentication-library-for-android#2247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small in change in response to changes in Android Common Refer below PRs.
common: AzureAD/microsoft-authentication-library-common-for-android#2573
Broker: https://github.com/AzureAD/ad-accounts-for-android/pull/3038