Move native auth interface towards parameters class methods, Fixes AB#3117217 #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
spetrescu84
reviewed
Jan 16, 2025
msal/src/main/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplication.kt
Show resolved
Hide resolved
spetrescu84
reviewed
Jan 16, 2025
msal/src/main/java/com/microsoft/identity/nativeauth/parameters/NativeAuthSignInParameters.kt
Outdated
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/parameters/NativeAuthSignUpParameters.kt
Outdated
Show resolved
Hide resolved
Yuki-YuXin
approved these changes
Jan 20, 2025
spetrescu84
reviewed
Jan 20, 2025
...c/test/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplicationJavaTest.java
Show resolved
Hide resolved
spetrescu84
approved these changes
Jan 20, 2025
nilo-ms
changed the title
|
One thing to mention, please update the change log file for the changes. Otherwise, use the tag "No-ChangeLog" For this PR, there might need to update the change log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#3117217
Add parameters class methods to native auth interface. Deprecate parameter list methods.
The signIn with continuation token method has a custom name for Java to avoid ambiguity. Without this custom name the introduction of the new method could introduce a breaking change in case the external developer used null as scopes value.
Additional info
The ideal test strategy for these new methods would be wrapping the
CommandDispatcherin a class and inject it a spy class during tests to check that the new parameters class is used properly. This refactor would require quite some time, so this work will be done in a separate PBI.