add build infrastructure for signing, analysis (#3)

AzureAD · Mar 14, 2019 · 6958afe · 6958afe
1 parent b5dd7e5
commit 6958afe
Show file tree

Hide file tree

Showing 9 changed files with 169 additions and 16 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -0,0 +1,20 @@
+<Project>
+  <PropertyGroup>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
+
+    <LangVersion>7.3</LangVersion>
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)/build/MSAL.snk</AssemblyOriginatorKeyFile>
+    <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)/build/SolutionWideAnalyzerConfig.ruleset</CodeAnalysisRuleSet>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
+  </PropertyGroup>
+  <ItemGroup>
+    <!-- PrivateAssets="All" is on these packages to ensure they're development dependencies
+         and aren't included as transitionary dependencies to package consumers.
+         For clarity, without PrivateAssets marked here, anyone consuming Microsoft.Identity.Client
+         would also be forced to install these dependencies.  PrivateAssets avoids this problem. -->
+    <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="All" />
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.3" PrivateAssets="All" />
+  </ItemGroup>
+</Project>
diff --git a/build/MSAL.snk b/build/MSAL.snk
diff --git a/build/SolutionWideAnalyzerConfig.ruleset b/build/SolutionWideAnalyzerConfig.ruleset
@@ -0,0 +1,126 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="MSAL Rules" Description="ADAL and MSAL rules." ToolsVersion="15.0">
+  <Rules AnalyzerId="AsyncUsageAnalyzers" RuleNamespace="AsyncUsageAnalyzers">
+    <Rule Id="AvoidAsyncSuffix" Action="None" />
+    <Rule Id="AvoidAsyncVoid" Action="None" />
+    <Rule Id="UseAsyncSuffix" Action="Error" />
+    <Rule Id="UseConfigureAwait" Action="Error" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.CodeQuality.Analyzers" RuleNamespace="Microsoft.CodeQuality.Analyzers">
+    <Rule Id="CA1000" Action="Error" />
+    <Rule Id="CA1008" Action="Error" />
+    <Rule Id="CA1010" Action="Error" />
+    <Rule Id="CA1012" Action="Error" />
+    <Rule Id="CA1016" Action="None" />
+    <Rule Id="CA1017" Action="Error" />
+    <Rule Id="CA1018" Action="Error" />
+    <Rule Id="CA1027" Action="Error" />
+    <Rule Id="CA1028" Action="Error" />
+    <Rule Id="CA1030" Action="Error" />
+    <Rule Id="CA1033" Action="Error" />
+    <Rule Id="CA1034" Action="Error" />
+    <Rule Id="CA1036" Action="Error" />
+    <Rule Id="CA1040" Action="None" />
+    <Rule Id="CA1041" Action="Error" />
+    <Rule Id="CA1043" Action="Error" />
+    <Rule Id="CA1044" Action="None" />
+    <Rule Id="CA1050" Action="Error" />
+    <Rule Id="CA1051" Action="None" />
+    <Rule Id="CA1052" Action="None" />
+    <Rule Id="CA1054" Action="None" />
+    <Rule Id="CA1055" Action="Error" />
+    <Rule Id="CA1056" Action="None" />
+    <Rule Id="CA1061" Action="Error" />
+    <Rule Id="CA1063" Action="None" />
+    <Rule Id="CA1064" Action="None" />
+    <Rule Id="CA1066" Action="None" />
+    <Rule Id="CA1067" Action="Error" />
+    <Rule Id="CA1068" Action="Error" />
+    <Rule Id="CA1505" Action="Error" />
+    <Rule Id="CA1707" Action="None" />
+    <Rule Id="CA1710" Action="None" />
+    <Rule Id="CA1714" Action="None" />
+    <Rule Id="CA1715" Action="None" />
+    <Rule Id="CA1716" Action="None" />
+    <Rule Id="CA1717" Action="None" />
+    <Rule Id="CA1720" Action="None" />
+    <Rule Id="CA1721" Action="None" />
+    <Rule Id="CA1724" Action="None" />
+    <Rule Id="CA1801" Action="None" />
+    <Rule Id="CA1802" Action="None" />
+    <Rule Id="CA1806" Action="None" />
+    <Rule Id="CA1812" Action="None" />
+    <Rule Id="CA1814" Action="None" />
+    <Rule Id="CA1815" Action="None" />
+    <Rule Id="CA1819" Action="None" />
+    <Rule Id="CA1822" Action="None" />
+    <Rule Id="CA1823" Action="None" />
+    <Rule Id="CA2007" Action="None" />
+    <Rule Id="CA2119" Action="None" />
+    <Rule Id="CA2211" Action="None" />
+    <Rule Id="CA2214" Action="None" />
+    <Rule Id="CA2219" Action="None" />
+    <Rule Id="CA2225" Action="None" />
+    <Rule Id="CA2226" Action="None" />
+    <Rule Id="CA2227" Action="None" />
+    <Rule Id="CA2231" Action="None" />
+    <Rule Id="CA2244" Action="None" />
+    <Rule Id="CA9999" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.CodeQuality.CSharp.Analyzers" RuleNamespace="Microsoft.CodeQuality.CSharp.Analyzers">
+    <Rule Id="CA1001" Action="None" />
+    <Rule Id="CA1032" Action="None" />
+    <Rule Id="CA1065" Action="None" />
+    <Rule Id="CA1200" Action="None" />
+    <Rule Id="CA1507" Action="None" />
+    <Rule Id="CA1821" Action="None" />
+    <Rule Id="CA2200" Action="None" />
+    <Rule Id="CA2234" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetCore.Analyzers" RuleNamespace="Microsoft.NetCore.Analyzers">
+    <Rule Id="CA1304" Action="Error" />
+    <Rule Id="CA1305" Action="Error" />
+    <Rule Id="CA1307" Action="None" />
+    <Rule Id="CA1308" Action="None" />
+    <Rule Id="CA1401" Action="None" />
+    <Rule Id="CA1816" Action="None" />
+    <Rule Id="CA1820" Action="None" />
+    <Rule Id="CA1826" Action="None" />
+    <Rule Id="CA2002" Action="None" />
+    <Rule Id="CA2008" Action="None" />
+    <Rule Id="CA2009" Action="None" />
+    <Rule Id="CA2101" Action="None" />
+    <Rule Id="CA2208" Action="None" />
+    <Rule Id="CA2216" Action="None" />
+    <Rule Id="CA2241" Action="None" />
+    <Rule Id="CA2242" Action="None" />
+    <Rule Id="CA2243" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetCore.CSharp.Analyzers" RuleNamespace="Microsoft.NetCore.CSharp.Analyzers">
+    <Rule Id="CA1810" Action="None" />
+    <Rule Id="CA1824" Action="None" />
+    <Rule Id="CA1825" Action="None" />
+    <Rule Id="CA2010" Action="None" />
+    <Rule Id="CA2201" Action="Error" />
+    <Rule Id="CA2207" Action="None" />
+    <Rule Id="CA5350" Action="None" />
+    <Rule Id="CA5351" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetFramework.Analyzers" RuleNamespace="Microsoft.NetFramework.Analyzers">
+    <Rule Id="CA1058" Action="None" />
+    <Rule Id="CA2153" Action="None" />
+    <Rule Id="CA2229" Action="None" />
+    <Rule Id="CA2235" Action="None" />
+    <Rule Id="CA2237" Action="None" />
+    <Rule Id="CA3075" Action="None" />
+    <Rule Id="CA3147" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetFramework.CSharp.Analyzers" RuleNamespace="Microsoft.NetFramework.CSharp.Analyzers">
+    <Rule Id="CA3076" Action="None" />
+    <Rule Id="CA3077" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
+    <Rule Id="SA1101" Action="None" />
+    <Rule Id="SX1101" Action="Error" />
+  </Rules>
+</RuleSet>
diff --git a/src/Microsoft.Identity.AdalExtensions/Class1.cs b/src/Microsoft.Identity.AdalExtensions/Class1.cs
@@ -1,8 +1,11 @@
-using System;
-
-namespace Microsoft.Identity.AdalExtensions
-{
-    public class Class1
-    {
-    }
-}
+using System;
+
+namespace Microsoft.Identity.AdalExtensions
+{
+    /// <summary>
+    ///
+    /// </summary>
+    public class Class1
+    {
+    }
+}
diff --git a/src/Microsoft.Identity.Extensions/Class1.cs b/src/Microsoft.Identity.Extensions/Class1.cs
@@ -5,6 +5,9 @@
 
 namespace Microsoft.Identity.Extensions
 {
+    /// <summary>
+    ///
+    /// </summary>
     public class Class1
     {
     }

diff --git a/src/Microsoft.Identity.Extensions/Microsoft.Identity.Extensions.csproj b/src/Microsoft.Identity.Extensions/Microsoft.Identity.Extensions.csproj
@@ -4,9 +4,4 @@
     <TargetFramework>netstandard2.0</TargetFramework>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.3" />
-    <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" />
-  </ItemGroup>
-
 </Project>
diff --git a/src/Microsoft.Identity.WebExtensions/Class1.cs b/src/Microsoft.Identity.WebExtensions/Class1.cs
@@ -5,6 +5,9 @@
 
 namespace Microsoft.Identity.WebExtensions
 {
+    /// <summary>
+    ///
+    /// </summary>
     public class Class1
     {
     }

diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props
@@ -0,0 +1,6 @@
+<Project>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..\'))" />
+  <PropertyGroup>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+  </PropertyGroup>
+</Project>
diff --git a/tests/Microsoft.Identity.Extensions.UnitTests/Microsoft.Identity.Extensions.UnitTests.csproj b/tests/Microsoft.Identity.Extensions.UnitTests/Microsoft.Identity.Extensions.UnitTests.csproj
@@ -9,9 +9,6 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
     <PackageReference Include="MSTest.TestAdapter" Version="1.3.2" />
     <PackageReference Include="MSTest.TestFramework" Version="1.3.2" />
-
-    <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.3" />
-    <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" />
   </ItemGroup>
 
   <ItemGroup>