Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for one hub network to have multiple firewall custom public IP addresses #76

Open
1 task done
VeronicaSea opened this issue Sep 23, 2024 · 1 comment
Open
1 task done
Labels
Type: Feature Request ➕ New feature or request

Comments

@VeronicaSea
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Support for one hub network to have multiple firewall custom public IP addresses.

Right now, this module only supports one hub network mapping to one default public IP, not support custom public IP addresses.

New or Affected Resource(s)/Data Source(s)

avm-ptn-hubnetworking

Potential Terraform Configuration

This could be configured in the following code block:

module "hub_firewalls" {
  for_each = local.firewalls
  source   = "Azure/avm-res-network-azurefirewall/azurerm"
  version  = "0.2.2"

  firewall_sku_name   = each.value.sku_name
  firewall_sku_tier   = each.value.sku_tier
  location            = var.hub_virtual_networks[each.key].location
  name                = each.value.name
  resource_group_name = var.hub_virtual_networks[each.key].resource_group_name
  firewall_ip_configuration = [{
    name                 = each.value.default_ip_configuration.name
    
    ### Support multiple custom public IP addresses as needed.
    public_ip_address_id = module.fw_default_ips[each.key].public_ip_id 

    subnet_id            = azurerm_subnet.fw_subnet[each.key].id
  }
]

References

https://github.com/Azure/terraform-azurerm-avm-res-network-azurefirewall

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Sep 23, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Oct 2, 2024
@matt-FFFFFF matt-FFFFFF added Type: Feature Request ➕ New feature or request and removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request ➕ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants