feat: add CPU/memory available capacity reporting in the InternalMemberCluster controller #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Do a sanity check to avoid inconsistencies. | ||
| if availableCPU.Cmp(resource.Quantity{}) < 0 { | ||
| availableCPU = resource.Quantity{} |
There was a problem hiding this comment.
when will this happen?
There was a problem hiding this comment.
Hi Ryan! The node list and the pod list does not happen at the same time, so it could happen that the available amount becomes negative.
| @@ -138,6 +138,7 @@ var _ = Describe("Test Internal Member Cluster Controller", Serial, func() { | |||
| By("checking updated member cluster usage") | |||
| Expect(imc.Status.ResourceUsage.Allocatable).ShouldNot(BeNil()) | |||
| Expect(imc.Status.ResourceUsage.Capacity).ShouldNot(BeNil()) | |||
| Expect(imc.Status.ResourceUsage.Available).ShouldNot(BeNil()) | |||
There was a problem hiding this comment.
check that the value is not zero?
There was a problem hiding this comment.
Hi Ryan! Actually a PR that refactors the tests on the InternalMemberCluster is in progress; would it be OK if this gets addressed in a separate PR? There will be a full check on the total/allocatable/available data.
ryanzhang-oss
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the ability to report CPU/memory available capacity in the InternalMemberCluster controller.
This change reflects a decision earlier to make the available CPU/memory capacity a core Fleet property.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Refactoring of the InternalMemberCluster controller tests is in progress and will be submitted separately.