feat: use new property name for node count property + specify the core properties (node count, total/allocatable/available CPU/memory) #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/scheduler/framework/plugins/clusteraffinity/filtering_test.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/framework/plugins/clusteraffinity/filtering_test.go
Outdated
Show resolved
Hide resolved
michaelawyu
changed the title
| @@ -136,6 +137,7 @@ var _ = Describe("Test Internal Member Cluster Controller", Serial, func() { | |||
| Expect(updatedHealthCond.Reason).To(Equal(EventReasonInternalMemberClusterHealthy)) | |||
|
|
|||
| By("checking updated member cluster usage") | |||
| Expect(imc.Status.Properties[propertyprovider.NodeCountProperty].Value).ShouldNot(BeEmpty()) | |||
There was a problem hiding this comment.
do we know how many nodes does this cluster have?
There was a problem hiding this comment.
With the dummy env I am not sure, but there will be a PR that re-factors the tests for this controller and we will using the full comparison like the one in the E2E tests for this part.
ryanzhang-oss
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates AKS property provider and related materials to use the new property name for the node count property (
kubernetes.azure.com/node-count->kubernetes-fleet.io/node-count),I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Important: changes in this PR should only be rolled out after the RP E2E tests are updated and rolled out.