feat: property-based scheduling: enable the property-based scheduling experience #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
previously approved these changes
Apr 4, 2024
| klog.ErrorS(err, "Failed to auto-discover region for the AKS property provider") | ||
| return err | ||
| klog.V(2).Info("Setting up the node tracker") | ||
| if p.nodeTracker == nil { |
There was a problem hiding this comment.
when will the node Tracker be not nil?
There was a problem hiding this comment.
Ah, this is for the case where a pricing provider is plugged in directly. Node tracker will be created here in the New function if no pricing provider is provided.
ryanzhang-oss
approved these changes
Apr 9, 2024
|
Merged to unblock the progress; if there's any concern, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR enables the property-based scheduling experience. It also adds additional E2E tests for the experience.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
No including all the tests for PR size reasons; additional tests will be submitted in separate PRs.