feat: add cluster resource override validation webhook configuration #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we don't need to create a separate validation webhook func. it can be part of the existing buildFleetValidatingWebhooks(). You can refer to how we validate member cluster CR. https://github.com/Azure/fleet/blob/main/pkg/webhook/webhook.go#L294 The core func is in the https://github.com/Azure/fleet/blob/main/pkg/utils/validator/membercluster.go#L19. Can you create the first PR to implement such util for the override first? |
britaniar
force-pushed
the
overrideValidationWebhook
branch
2 times, most recently
from
abcf286 to
63da312
Compare
britaniar
changed the title
britaniar
changed the title
britaniar
force-pushed
the
overrideValidationWebhook
branch
from
82d0e14 to
3443991
Compare
|
There was an error handling pipeline event e4b3bca9-4737-4952-9b85-6192f019c61a. |
britaniar
force-pushed
the
overrideValidationWebhook
branch
from
1daba13 to
29517be
Compare
britaniar
force-pushed
the
overrideValidationWebhook
branch
from
29517be to
755feb6
Compare
zhiying-lin
reviewed
Mar 27, 2024
zhiying-lin
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have: added webhook configuration for ClusterResourceOverride
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer