Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update helm chart with new values #693

Merged
merged 14 commits into from
Mar 20, 2024

Conversation

britaniar
Copy link
Contributor

Description of your changes

update helm chart with new values

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@britaniar britaniar marked this pull request as ready for review February 22, 2024 21:34
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
@britaniar britaniar force-pushed the update-helm-chart branch 2 times, most recently from 0140ec1 to f25d7e4 Compare March 12, 2024 18:05
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to bump the default klog info level

charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the test failure issue everything LGTM. Will add approval when the tests turn green.

test/e2e/setup.sh Outdated Show resolved Hide resolved
charts/hub-agent/README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
michaelawyu
michaelawyu previously approved these changes Mar 15, 2024
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ryanzhang-oss
ryanzhang-oss previously approved these changes Mar 18, 2024
@britaniar britaniar merged commit 8c09fb5 into Azure:main Mar 20, 2024
12 checks passed
@britaniar britaniar deleted the update-helm-chart branch March 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants