Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random eslint errors #5289

Merged
merged 16 commits into from
Oct 10, 2024
Merged

Fix random eslint errors #5289

merged 16 commits into from
Oct 10, 2024

Conversation

carocao-msft
Copy link
Contributor

@carocao-msft carocao-msft commented Oct 9, 2024 •
edited by JamesBurnside
Loading

What

Fix random eslint errors

Why

prettier/eslint-plugin-prettier#671

Fixes: #5286

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Oct 9, 2024
@carocao-msft carocao-msft requested review from a team as code owners October 9, 2024 20:14
dmceachernmsft and others added 4 commits October 9, 2024 20:16
@dmceachernmsft @carocao-msft
[JS-loaders] Conceptual docs (#5202)
5f9fa15 
* initial docs

* add docs

* links

* FAQ

* add lazy load snippet

* comment nit

* fix nits

* update for new API
@emlynmac @carocao-msft
Dependency updates (#5285)
435541e 
* Remove CPX from lockfiles

* Remove old braces versions from lockfile

* Update auto-installer to cpy-cli v5

* Update eslint-plugin-mdx

* Update vulnerable deps
@dmceachernmsft @carocao-msft
[A11y bugfix] Make reactions button Keyboard accessible (#5281)
0950e00 
* refactor button to use callout

* update component ref and styles

* changelog

* remove console

* fix test

* fix spacing
@carocao-msft
lint fix
c5bd225
@carocao-msft carocao-msft changed the base branch from main to users/merlinbot/1es-pt-auto-baselining-pr October 9, 2024 20:18
@carocao-msft carocao-msft changed the base branch from users/merlinbot/1es-pt-auto-baselining-pr to main October 9, 2024 20:18
JamesBurnside
JamesBurnside requested changes Oct 9, 2024
View reviewed changes
common/config/rush/pnpm-lock.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-luvsutumbd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-szpshfscqt.chromatic.com/

@emlynmac
Copy link
Member

emlynmac commented Oct 9, 2024

If we're now overriding to use synckit at version 0.8.8, do we need an explicit dev dependency for it?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wasxxrrtfy.chromatic.com/

@carocao-msft carocao-msft marked this pull request as draft October 9, 2024 22:54
@carocao-msft carocao-msft marked this pull request as ready for review October 9, 2024 23:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pbeflktsip.chromatic.com/

JamesBurnside
JamesBurnside reviewed Oct 10, 2024
View reviewed changes
packages/acs-ui-common/package.json
"typescript": "5.4.5",
"synckit": "0.8.8"
},
"overrides": {
Copy link
Member

@JamesBurnside JamesBurnside Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Suggestion, non-blocking) Could this instead be in the common-versions files? Just that it would allow the change to be kept to one file and, more importantly, allow a comment why it's been added. (otherwise someone will need to git blame and look up this PR to understand why this is present in the package.json)

JamesBurnside
JamesBurnside requested changes Oct 10, 2024
View reviewed changes
packages/communication-react/package.json
},
"beachball": {
"shouldPublish": false
},
"overrides": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything in this package.json gets published to our npm package, can you add to here:

communication-ui-library/common/scripts/prepare-package-json.js

Line 15 in 8f6ab24

delete result.beachball;
a delete of this overrides section

emlynmac
emlynmac approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good now; no cpx in the lock files and we have the synckit 0.8.8 dep

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-acebthpiku.chromatic.com/

@carocao-msft carocao-msft enabled auto-merge (squash) October 10, 2024 20:50
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qexzzlysqj.chromatic.com/

@carocao-msft carocao-msft merged commit e863b3b into main Oct 10, 2024
39 checks passed
@carocao-msft carocao-msft deleted the carocao/lint branch October 10, 2024 21:02
carocao-msft added a commit that referenced this pull request Oct 10, 2024
@carocao-msft
Revert "Fix random eslint errors (#5289)"
42da6e7 
This reverts commit e863b3b.
@carocao-msft carocao-msft mentioned this pull request Oct 10, 2024
Merged
carocao-msft added a commit that referenced this pull request Oct 11, 2024
@carocao-msft
Revert "Fix random eslint errors (#5289)" (#5301)
16e7f71 
This reverts commit e863b3b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@edwardlee-msft edwardlee-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Main branch CI Failed
5 participants
@carocao-msft @emlynmac @JamesBurnside @edwardlee-msft @dmceachernmsft