Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url optional #3884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make url optional #3884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8419cd
make url optional
iamrk04 Feb 28, 2025
6d2dbd7
Merge branch 'main' into rk/batch_config
iamrk04 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions assets/aml-benchmark/components/batch_benchmark_config_generator/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ type: command
name: batch_benchmark_config_generator
display_name: Batch Benchmark Config Generator
description: Generates the config for the batch score component.
version: 0.0.10
version: 0.0.11
is_deterministic: true

inputs:
Expand All @@ -14,8 +14,8 @@ inputs:
description: An optional configuration file to use for deployment settings. This overrides passed in parameters.
scoring_url:
type: string
optional: false
description: The URL of the endpoint.
optional: true
description: The URL of the endpoint. Optional only if this field is provided in the configuration_file.
model_type:
type: string
description: Type of model. Can be one of ('oai', 'oss', 'vision_oss')
Expand Down Expand Up @@ -89,7 +89,6 @@ code: ../src
environment: azureml://registries/azureml/environments/evaluation/versions/5
command: >-
python -m aml_benchmark.batch_config_generator.main
--scoring_url '${{inputs.scoring_url}}'
--model_type ${{inputs.model_type}}
--authentication_type ${{inputs.authentication_type}}
--debug_mode ${{inputs.debug_mode}}
Expand All @@ -98,7 +97,8 @@ command: >-
--max_worker_count ${{inputs.max_worker_count}}
--response_segment_size ${{inputs.response_segment_size}}
--batch_score_config_path ${{outputs.batch_score_config}}
$[[--configuration_file ${{inputs.configuration_file}}]]
$[[--scoring_url '${{inputs.scoring_url}}']]
$[[--configuration_file '${{inputs.configuration_file}}']]
$[[--max_retry_time_interval ${{inputs.max_retry_time_interval}}]]
$[[--connection_name '${{inputs.connection_name}}']]
$[[--deployment_name '${{inputs.deployment_name}}']]
Expand Down
5 changes: 3 additions & 2 deletions assets/aml-benchmark/components/src/aml_benchmark/batch_config_generator/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ def parse_args() -> argparse.Namespace:
parser.add_argument(
"--scoring_url",
type=str,
help="The URL of the endpoint."
help="The URL of the endpoint.",
default=None,
)
parser.add_argument(
"--connection_name",
Expand Down Expand Up @@ -248,7 +249,7 @@ def _get_overriding_configs(configuration_file: Optional[str]) -> Dict[Any, Any]

@swallow_all_exceptions(logger)
def main(
scoring_url: str,
scoring_url: Optional[str],
connection_name: str,
authentication_type: AuthenticationType,
debug_mode: bool,
Expand Down
Loading