-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model monitoring CI test failures due to conflicts with uploaded artifact names #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59a4677
to
dce403a
Compare
qusongms
approved these changes
Feb 10, 2025
Test Results for model-monitoring-gsq-ci13 tests 13 ✅ 1h 48m 53s ⏱️ Results for commit dce403a. |
alanpo1
approved these changes
Feb 10, 2025
vizhur
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test failures in model monitoring CI during "upload test results" step due to name conflict:

With updated v4 version of
actions/upload-artifact
name conflicts are no longer automatically overwritten. This is resolved by updating the artifact names which are now unique by appending the matrix group number to the artifact name.In addition, fixing numpy errors by pinning numpy<2.0.0 and updating the versions on all components, which fixes the e2e test failures.
Copilot summary:
This pull request includes updates to various YAML specification files and CI workflow configurations to enhance the model monitoring components and ensure compatibility with the latest dependencies. The most important changes involve updating component versions and adding a new dependency.
CI Workflow Enhancements:
.github/workflows/model-monitoring-ci.yml
: Added a matrix strategy for grouping test results and modified artifact names to include the matrix group. [1] [2]Component Version Updates:
assets/model_monitoring/components/data_drift/data_drift_compute_metrics/spec.yaml
: Updated version from0.3.29
to0.3.30
.assets/model_monitoring/components/data_drift/data_drift_signal_monitor/spec.yaml
: Updated multiple component versions to the latest available. [1] [2] [3] [4] [5] [6] [7] [8] [9]assets/model_monitoring/components/data_quality/data_quality_compute_metrics/spec.yaml
: Updated version from0.3.28
to0.3.29
.assets/model_monitoring/components/data_quality/data_quality_signal_monitor/spec.yaml
: Updated multiple component versions to the latest available. [1] [2] [3] [4] [5] [6] [7] [8] [9]assets/model_monitoring/components/data_quality/data_quality_statistics/spec.yaml
: Updated version from0.3.23
to0.3.24
.assets/model_monitoring/components/feature_attribution_drift/feature_attribution_drift_compute_metrics/spec.yaml
: Updated version from0.3.24
to0.3.25
.assets/model_monitoring/components/feature_attribution_drift/feature_attribution_drift_signal_monitor/spec.yaml
: Updated multiple component versions to the latest available. [1] [2] [3] [4]Dependency Updates:
numpy<2.0.0
to theconf
section in several component specification files to ensure compatibility with existing code. [1] [2] [3] [4] [5]