-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable input column, label column for vision tasks #3016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjaincc
reviewed
Jun 6, 2024
Test Results for training-model-mgmt-unittests44 tests 44 ✅ 8s ⏱️ Results for commit 9bb6ea7. |
ankushbhatia2
previously approved these changes
Jun 11, 2024
ankushbhatia2
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (benchmarking the Stable Diffusion model on MSCOCO): main...rdondera/sd
Honor column name parameters (inputs, label) passed to the model prediction component for vision tasks. This does not bring benefits for image classification, object detection or instance segmentation, but is needed for image generation tasks, where the input name depends on the model.
Also: clarified how vision dataset processing works in the model evaluation pipeline. The MLTable is assumed to have columns "image_url" and "label" and the Pandas dataframe created from it has columns set according to the input_column_names and label_column_name parameters. When these parameters are not specified, task specific default values are filled in.
Also: brought back changes from #2888 , which were removed in a subsequent PR.
Tested by running the evaluation pipeline for ViT in the cloud: https://ml.azure.com/experiments/id/9f7237b4-3232-49d3-ae02-e07326242835?wsid=/subscriptions/dbd697c3-ef40-488f-83e6-5ad4dfb78f9b/resourcegroups/rdondera/providers/Microsoft.MachineLearningServices/workspaces/benchmarking&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 , vit_*.