Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable input column, label column for vision tasks #3016

Merged
merged 14 commits into from
Jun 24, 2024

Conversation

rdondera-microsoft
Copy link
Contributor

@rdondera-microsoft rdondera-microsoft commented Jun 5, 2024

Context (benchmarking the Stable Diffusion model on MSCOCO): main...rdondera/sd

Honor column name parameters (inputs, label) passed to the model prediction component for vision tasks. This does not bring benefits for image classification, object detection or instance segmentation, but is needed for image generation tasks, where the input name depends on the model.

Also: clarified how vision dataset processing works in the model evaluation pipeline. The MLTable is assumed to have columns "image_url" and "label" and the Pandas dataframe created from it has columns set according to the input_column_names and label_column_name parameters. When these parameters are not specified, task specific default values are filled in.

Also: brought back changes from #2888 , which were removed in a subsequent PR.

Tested by running the evaluation pipeline for ViT in the cloud: https://ml.azure.com/experiments/id/9f7237b4-3232-49d3-ae02-e07326242835?wsid=/subscriptions/dbd697c3-ef40-488f-83e6-5ad4dfb78f9b/resourcegroups/rdondera/providers/Microsoft.MachineLearningServices/workspaces/benchmarking&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 , vit_*.

  1. vit_params: both input_column_names and label_column_name properly set ("image", "label")
  2. vit_params: neither input_column_names nor label_column_name set
  3. vit_wrong_params: both input_column_names and label_column_name set to wrong values ("rgb_image", "class")
  4. vit_wrong_label: input_column_names properly set, label_column_name set to wrong value ("image", "class,attribute")

@rdondera-microsoft rdondera-microsoft changed the title Enable input column names, label column for vision tasks Enable input column, label column for vision tasks Jun 5, 2024
@rdondera-microsoft rdondera-microsoft marked this pull request as ready for review June 5, 2024 22:03
@rdondera-microsoft rdondera-microsoft requested a review from a team as a code owner June 5, 2024 22:03
Copy link

github-actions bot commented Jun 7, 2024

Test Results for training-model-mgmt-unittests

44 tests   44 ✅  8s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 9bb6ea7.

ankushbhatia2
ankushbhatia2 previously approved these changes Jun 11, 2024
@rdondera-microsoft rdondera-microsoft merged commit a8c8565 into main Jun 24, 2024
17 checks passed
@rdondera-microsoft rdondera-microsoft deleted the rdondera/vision_parameters branch June 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants