Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main into branch #2361

Merged
merged 2 commits into from
Feb 21, 2024
Merged

merge main into branch #2361

merged 2 commits into from
Feb 21, 2024

Conversation

alanpo1
Copy link
Member

@alanpo1 alanpo1 commented Feb 21, 2024

No description provided.

shreeyaharma and others added 2 commits February 21, 2024 14:30
* Add exec instances for mdc and genai

* bump the version for mdc and genai
* add barebones component

* add simple component logic

* add resource and identity to signal spec

* add comment

* Revert "add resource and identity to signal spec"

This reverts commit 09e4024.

* Revert "add simple component logic"

This reverts commit dd484a3.

* Update spec.yaml
@alanpo1 alanpo1 requested a review from a team as a code owner February 21, 2024 23:01
@alanpo1 alanpo1 merged commit 81626ae into alanpoblette/add-gsq-adaptor-to-signal Feb 21, 2024
5 checks passed
alanpo1 added a commit that referenced this pull request Feb 29, 2024
* add adaptor to the signal

* merge main into branch (#2361)

* Add exec instances (#2360)

* Add exec instances for mdc and genai

* bump the version for mdc and genai

* Simple GSQ Input Schema Adaptor component (#2357)

* add barebones component

* add simple component logic

* add resource and identity to signal spec

* add comment

* Revert "add resource and identity to signal spec"

This reverts commit 09e4024.

* Revert "add simple component logic"

This reverts commit dd484a3.

* Update spec.yaml

---------

Co-authored-by: shreeyaharma <[email protected]>

* add pip dependency and mode: direct for input

* wip logic

* add promote logic

* try different approaches for adapting data

* add new data asset for trace logs

* add genai data GSQ e2e test

* add tests for GenAI input schema adaptor

* replace e2e genai asset with parquet file for proper data format

* fix UT

* add shared utils for accessing df columns

* comment unused import

* syntax

* syntax

* remove duplicated logic

* unused import

* add gsq test mark

* set fixture on function

* select only gsq columns if present

* adjust UT for no data fallthrough

* unused import

* update error msg

* pass all promoted fields through to gsq

* syntax

* add small trace log sample data

* enable genai gsq test

* add empty string

* revert change

* comment out cause data is not working

* add correct csv data for genai gsq test

* move constants to shared utilities

* fix data for reading

* syntax

* add malformed json string validation

* add test for bad json string in input/output columns

* syntax

* add invalid json testcase

* sample subset of data for spark.jsonl.read

* add has_duplicate_columns validation error for component

* syntax and style

* syntax

* Update test_df_utils.py

* comment out hard to repro testcase

* unused import

* use simpler logic for has_duplicate_columns

* Speed up model-monitoring-ci (#2395)

* add pytest-split and split into groups for speed-up

* add .test_durations to ci

* modify conftest to run certain fixtures only if we haven't ran them in github action yet

* add python with pytest to previous step

* try calling fixture with name argument

* conditionally upload components

* unused import

* syntax

* fix syntax

* checkout branch

* use azure create resources

* use correct path

* use test requirements

* login to az cli

* increase group size

* pass on execution context output

* syntax

* Revert "increase group size"

This reverts commit d87ab15.

* syntax

* depend on check-execution-context

* put version file in root

* early exit asset_version if components published

* fix import statements

* change message

* add reason to skipif

* use 10 jobs

* syntax

* use 7 splits

* Revert "fix import statements"

This reverts commit b47db43.

* use module imports

* add module inits

* don't continue on error for .version_upload file

* upgrade specs for updated component code

* Update model-monitoring-ci.yml

* Revert "Speed up model-monitoring-ci (#2395)"

This reverts commit e90deb2.

---------

Co-authored-by: shreeyaharma <[email protected]>
anushree1808 pushed a commit to anushree1808/azureml-assets that referenced this pull request Apr 23, 2024
* add adaptor to the signal

* merge main into branch (Azure#2361)

* Add exec instances (Azure#2360)

* Add exec instances for mdc and genai

* bump the version for mdc and genai

* Simple GSQ Input Schema Adaptor component (Azure#2357)

* add barebones component

* add simple component logic

* add resource and identity to signal spec

* add comment

* Revert "add resource and identity to signal spec"

This reverts commit 49ee64dfa4564e254ddb33e27c3311ef9ba2638e.

* Revert "add simple component logic"

This reverts commit 515583c713b62f58c749951fb5e908cc08025ba8.

* Update spec.yaml

---------

Co-authored-by: shreeyaharma <[email protected]>

* add pip dependency and mode: direct for input

* wip logic

* add promote logic

* try different approaches for adapting data

* add new data asset for trace logs

* add genai data GSQ e2e test

* add tests for GenAI input schema adaptor

* replace e2e genai asset with parquet file for proper data format

* fix UT

* add shared utils for accessing df columns

* comment unused import

* syntax

* syntax

* remove duplicated logic

* unused import

* add gsq test mark

* set fixture on function

* select only gsq columns if present

* adjust UT for no data fallthrough

* unused import

* update error msg

* pass all promoted fields through to gsq

* syntax

* add small trace log sample data

* enable genai gsq test

* add empty string

* revert change

* comment out cause data is not working

* add correct csv data for genai gsq test

* move constants to shared utilities

* fix data for reading

* syntax

* add malformed json string validation

* add test for bad json string in input/output columns

* syntax

* add invalid json testcase

* sample subset of data for spark.jsonl.read

* add has_duplicate_columns validation error for component

* syntax and style

* syntax

* Update test_df_utils.py

* comment out hard to repro testcase

* unused import

* use simpler logic for has_duplicate_columns

* Speed up model-monitoring-ci (Azure#2395)

* add pytest-split and split into groups for speed-up

* add .test_durations to ci

* modify conftest to run certain fixtures only if we haven't ran them in github action yet

* add python with pytest to previous step

* try calling fixture with name argument

* conditionally upload components

* unused import

* syntax

* fix syntax

* checkout branch

* use azure create resources

* use correct path

* use test requirements

* login to az cli

* increase group size

* pass on execution context output

* syntax

* Revert "increase group size"

This reverts commit 5df0ad3.

* syntax

* depend on check-execution-context

* put version file in root

* early exit asset_version if components published

* fix import statements

* change message

* add reason to skipif

* use 10 jobs

* syntax

* use 7 splits

* Revert "fix import statements"

This reverts commit bd8cace.

* use module imports

* add module inits

* don't continue on error for .version_upload file

* upgrade specs for updated component code

* Update model-monitoring-ci.yml

* Revert "Speed up model-monitoring-ci (Azure#2395)"

This reverts commit ed90255.

---------

Co-authored-by: shreeyaharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants