fix: sidecar doesn't work properly for Microsoft ODBC Driver for SQL (#593) #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
reviewed
Mar 1, 2023
| @@ -57,7 +57,7 @@ type token struct { | |||
| RefreshToken string `json:"refresh_token"` | |||
|
|
|||
| // AAD returns expires_in as a string, ADFS returns it as an int | |||
| ExpiresIn json.Number `json:"expires_in"` | |||
| ExpiresIn string `json:"expires_in"` | |||
There was a problem hiding this comment.
@skythet As mentioned in the comment, this struct was vendor-ed from the go SDK: https://github.com/Azure/go-autorest/blob/b3899c1057425994796c92293e931f334af63b4e/autorest/adal/token.go#L1055-L1067. This has been the default behavior for a while.
What language SDK are you using? Also, another user opened #773, which seems to indicate the proxy sidecar is working fine with their ODBC.
There was a problem hiding this comment.
@skythet ping! Did you get a chance to look at the comment?
|
Closing this due to inactivity. Feel free to reopen when you get a chance to look at the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Proxy defines expires_in as a "number", while odbc drivers expects "string". Because
of this jdbc drivers are failing to parse retrieved token. A bit more details in this comment.
Internally we have replaced proxy to patched version and java jdbc driver started working
properly.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: