Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow proxies to be injected using a native sidecar #1442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devjoes
Copy link

@devjoes devjoes commented Aug 21, 2024

Reason for Change:

Fixes Issue 773 by using native sidecars so that pods exit cleanly when running as cronjobs, currently azwi sidecar prevents the pod from terminating.

It also addresses an annoyance where the first container in the pod is the proxy, so any kubectl commands target that container, previously I was working around this by adding the default-container annotation.

I've kept the current behaviour as the default because this change requires at least k8s 1.28, adding the annotation azure.workload.identity/use-native-sidecar enables native sidecars. But it seems to work well so at some point in the future you could just make this the default behaviour.

No update to deployment.yaml

No change to Helm chart

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Fixes #733

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:
Tested on v1.30.0-eks-fff26e3

@devjoes devjoes requested review from aramase and enj as code owners August 21, 2024 10:04
@devjoes
Copy link
Author

devjoes commented Aug 21, 2024

@microsoft-github-policy-service agree

@devjoes
Copy link
Author

devjoes commented Sep 9, 2024

@aramase @enj any update on this PR? I've just rebased it and messaged our MS TAMs to see if they can do anything to get it merged.

@bench
Copy link

bench commented Dec 9, 2024

Hi,
Can we have any news for this PR please :)
@aramase @enj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure.workload.identity/inject-proxy-sidecar blocks jobs in Kubernetes
2 participants