feat: allow proxies to be injected using a native sidecar #1442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fixes Issue 773 by using native sidecars so that pods exit cleanly when running as cronjobs, currently azwi sidecar prevents the pod from terminating.
It also addresses an annoyance where the first container in the pod is the proxy, so any
kubectl
commands target that container, previously I was working around this by adding the default-container annotation.I've kept the current behaviour as the default because this change requires at least k8s 1.28, adding the annotation
azure.workload.identity/use-native-sidecar
enables native sidecars. But it seems to work well so at some point in the future you could just make this the default behaviour.No update to deployment.yaml
No change to Helm chart
Requirements
Issue Fixed:
Fixes #733
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers:
Tested on v1.30.0-eks-fff26e3