Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use azure storage static web serving rather than public access #1359

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented May 23, 2024

$web container is a special container that serves static web content without requiring public access enablement (xref: https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-static-website)

@aramase aramase requested a review from enj as a code owner May 23, 2024 17:05
@aramase aramase requested a review from sozercan May 23, 2024 17:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.55%. Comparing base (3874533) to head (e126a3b).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   51.66%   52.55%   +0.88%     
==========================================
  Files          53       53              
  Lines        2938     2445     -493     
==========================================
- Hits         1518     1285     -233     
+ Misses       1378     1118     -260     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aramase aramase enabled auto-merge (squash) May 23, 2024 21:23
@aramase aramase self-assigned this Jun 18, 2024
@aramase aramase merged commit 76f0505 into Azure:main Jun 18, 2024
22 checks passed
@aramase aramase deleted the aramase/c/static_web_kind_setup branch June 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants