ci: remove pinned k8s version for aks clusters #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <[email protected]>
aramase
commented
Apr 30, 2024
Comment on lines
-28
to
-29
| # pin to the minor version and aks will pick the latest patch version | ||
| KUBERNETES_VERSION="1.26" |
There was a problem hiding this comment.
We have a test matrix with kind clusters, so relying on default version for AKS cluster creation should be fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
+ Coverage 51.66% 52.90% +1.23%
==========================================
Files 53 53
Lines 2938 2429 -509
==========================================
- Hits 1518 1285 -233
+ Misses 1378 1102 -276
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anish Ramasekar <[email protected]>
aramase
force-pushed
the
aramase/ci/update_k8s_version
branch
from
caab2a9 to
cff5127
Compare
enj
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Remove pinned k8s version for aks clusters in CI.
This will resolve cluster creation failure in CI: https://dev.azure.com/AzureContainerUpstream/Azure%20Workload%20Identity/_build/results?buildId=162979&view=logs&jobId=377f0d06-9179-5249-f9a7-28bb5766ad7b&j=b3c1b3ef-28d7-5409-0106-cc1f1619b84c&t=9e7e4005-272c-58b2-628a-739ad1a735d9