-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump k8s deps to v1.29.4 and controller-runtime to v0.17.3 #1292
Conversation
c07bcc4
to
20271a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 51.66% 52.55% +0.88%
==========================================
Files 53 53
Lines 2938 2445 -493
==========================================
- Hits 1518 1285 -233
+ Misses 1378 1118 -260
Partials 42 42 ☔ View full report in Codecov by Sentry. |
20271a6
to
3c951e2
Compare
455d0a7
to
d4d40de
Compare
67a2f70
to
ecf516e
Compare
@enj Can you look this pr, should fix this issue Kubernetes native sidecar not supported |
b2940a1
to
4954d88
Compare
I've added a unit test in 9640c58 to assert the existing failure and the bump of deps fix it. === RUN TestHandle/pod_has_the_required_label,_restart_policy_in_init_container
webhook_test.go:806: expected no remove patches, got: {remove /spec/initContainers/0/restartPolicy <nil>} |
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
0e961ae
to
4a2a7a5
Compare
fixes #1312