Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm chart): Make env vars configurable and auto configure go runtime #1246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ spec:
- --metrics-backend={{ .Values.metricsBackend }}
command:
- /manager
env:
{{- with .Values.goEnvVars }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.extraEnvVars }}
{{- toYaml . | nindent 8 }}
{{- end }}
envFrom:
- configMapRef:
name: azure-wi-webhook-config
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ helm upgrade -n azure-workload-identity-system [RELEASE_NAME] azure-workload-ide
| image.pullPolicy | Image pullPolicy | `IfNotPresent` |
| image.release | The image release tag to use | Current release version: `v1.2.0` |
| imagePullSecrets | Image pull secrets to use for retrieving images from private registries | `[]` |
| goEnvVars | Go runtime environment variables to pass to the azure-wi-webhook-controller-manager's _manager_ container. | `See _values.yaml_` |
| extraEnvVars | Additional environment variables to pass to the azure-wi-webhook-controller-manager's _manager_ container. | `[]` |
| nodeSelector | The node selector to use for pod scheduling | `kubernetes.io/os: linux` |
| resources | The resource request/limits for the container image | limits: 100m CPU, 30Mi, requests: 100m CPU, 20Mi |
| affinity | The node affinity to use for pod scheduling | `{}` |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ image:
# Overrides the image tag whose default is the chart appVersion.
release: v1.2.0
imagePullSecrets: []
goEnvVars:
- name: GOMAXPROCS
valueFrom:
resourceFieldRef:
resource: requests.cpu
- name: GOMEMLIMIT
valueFrom:
resourceFieldRef:
resource: limits.memory
nodeSelector:
kubernetes.io/os: linux
resources:
Expand Down