chore: Update .NET sample to use MSAL best practices #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
changed the title
aramase
requested changes
Oct 20, 2023
pmaytak
reviewed
Oct 27, 2023
pmaytak
reviewed
Oct 27, 2023
pmaytak
approved these changes
Oct 27, 2023
aramase
reviewed
Nov 30, 2023
There was a problem hiding this comment.
@bgavrilMS ping on this one! Are you still working on the PR?
|
Thanks for the ping @aramase, taking a look. |
aramase
changed the title
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
aramase
approved these changes
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 55.49% 55.49%
=======================================
Files 36 36
Lines 2294 2294
=======================================
Hits 1273 1273
Misses 980 980
Partials 41 41 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The MSAL samples do not showcase MSAL best practices such as token caching, authority configuration and assertion refresh.
Source: I am the engineering manager for MSAL.NET
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: