Fix filename parser to support digits in artifact name #9794
+89
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanGiles
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
LGTM. The only annoying thing is that I am still waiting for the v2 parser to be merged over here: #9394
There will be a merge conflict one way or the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the filename parser to support digits in the artifact name. The previous parser assumed the first digit in the filename was the start of the version number, which caused issues when the artifact name contained digits. The change uses regex pattern matcher to identify the artifact ID and package version in the filename.