-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement per-service test setup #1985
Merged
LarryOsterman
merged 102 commits into
Azure:main
from
LarryOsterman:larryo/per_package_test_scripts
Jan 15, 2025
Merged
Implement per-service test setup #1985
LarryOsterman
merged 102 commits into
Azure:main
from
LarryOsterman:larryo/per_package_test_scripts
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
reviewed
Jan 9, 2025
heaths
reviewed
Jan 9, 2025
heaths
reviewed
Jan 9, 2025
heaths
reviewed
Jan 9, 2025
/azp run rust - pr |
Azure Pipelines successfully started running 1 pipeline(s). |
hallipr
reviewed
Jan 15, 2025
hallipr
reviewed
Jan 15, 2025
heaths
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for per-service/per-package test setup and cleanup scripts, and implement scripts for the azure_core_amqp package.
Note that this includes a gratuitous change to lib.rs to trigger the test script.
CoPilot Summary
This pull request introduces several updates to the testing scripts and setup for the
azure_core_amqp
package. The most important changes involve adding a working directory parameter, integrating setup and cleanup scripts for package tests, and specific setup for theazure_core_amqp
package.Updates to testing scripts:
eng/pipelines/templates/steps/test-packages.yml
: Added-WorkingDirectory '$(Build.SourcesDirectory)'
argument to the test packages step.eng/scripts/Test-Packages.ps1
:workingDirectory
parameter to the script.Test-Setup.ps1
andTest-Cleanup.ps1
scripts if they exist. [1] [2]Setup and Cleanup scripts:
sdk/core/Test-Setup.ps1
:azure_core_amqp
package, including cloning the repository, building the test broker, and starting it.sdk/core/Test-Cleanup.ps1
:azure_core_amqp
package, including stopping the test broker.Minor code changes:
sdk/core/azure_core_amqp/src/lib.rs
: Added a newline for formatting consistency.