Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous call issue in one of the VirtualMachineScaleSetData model factory methods #48106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 5, 2025

This PR added a few new overloads to VirtualMachineScaleSetData method in model factory, but I forgot to change those shared parameters to required, now if we use:

var data = ArmComputeModelFactory.VirtualMachineScaleSetData(location: "eastus");

we will have ambiguous call error.

This PR is trying to resolve this.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ArcturusZhang ArcturusZhang marked this pull request as ready for review February 5, 2025 05:33
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 5, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Compute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants