Adopt MSAL managed identity implementation #24156
Open
+303
−634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
requested review from
jhendrixMSFT,
RickWinter and
a team
as code owners
chlowell
requested review from
christothes,
joshfree,
g2vinay,
schaabs,
mpodwysocki,
xiangyan99 and
minhanh-phan
| res, err := req.Next() | ||
| if err == nil { | ||
| // if the response is a recording mismatch, return it as a simple error that prints clearly in the test log | ||
| if e := res.Header.Get("x-request-mismatch-error"); e != "" { |
There was a problem hiding this comment.
This seems duplicated from your same change in /sdk/internal. I guess that hasn't been released yet though. Will this go away once that happens?
There was a problem hiding this comment.
Yes, I'll remove this before merging
jhendrixMSFT
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20409. This is mostly straightforward refactoring, however the switch broke most of our tests because MSAL uses a per-process cache for managed identity tokens whereas we used a per-client cache.