Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user management #261

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

leo-schick
Copy link
Contributor

@leo-schick leo-schick commented Jan 13, 2024

I did some work in order to improve the user management. This was requrested in #225 as well.

Task list:

  • add request to get a single user from the Saas.Permissions API (GetTenantUser)
  • add request to get a single user from the Saas.Admin API ({tenantId}/Users/{userId})
  • adding views for Edit, Details and Delete (functionality for Edit and Delete are missing)
  • finalize API to edit users (UI is alredy implemented but returns 404 NOT FOUND)
  • finalize API to delete users (UI is alredy implemented but returns 404 NOT FOUND)
    Note: The delete function should not be able to delete the last admin user of a tenant (!)

@leo-schick
Copy link
Contributor Author

@1iveowl maybe you could implement the missing API functions?

This PR could be be merged already now since it does not add any harm but just improves the currently incomplete implementation of the user management.

@1iveowl
Copy link
Collaborator

1iveowl commented Jan 13, 2024

@1iveowl maybe you could implement the missing API functions?

This PR could be be merged already now since it does not add any harm but just improves the currently incomplete implementation of the user management.

Thank you @leo-schick. Current dev work is centeret around researching the introduction of Microsoft Entra External Id to replace Azure B2C. If you want to add the missing APIs please feel free to do so.

I will go ahead and merge what you have already created. Thank you for your contribution.

@1iveowl 1iveowl merged commit 879388e into Azure:main Jan 13, 2024
1 check passed
@leo-schick leo-schick deleted the improve-user-management branch January 13, 2024 18:18
@1iveowl 1iveowl self-assigned this Jan 20, 2024
@1iveowl 1iveowl self-requested a review January 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants