Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{HDInsight} Update hilo readme files #25321

Merged
merged 4 commits into from
Aug 23, 2023
Merged

{HDInsight} Update hilo readme files #25321

merged 4 commits into from
Aug 23, 2023

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Aug 16, 2023 •
edited by openapi-workflow-bot bot
Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-workflow-bot
Copy link

Hi, @aim-for-better! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023 •
    edited
    Loading

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.4) new version base version
    default default(4627416) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-resource-manager-schemas failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hdinsightcontainers/armhdinsightcontainers https://apiview.dev/Assemblies/Review/62c3b050eac341a68565e92a540d86ba
    .Net Azure.ResourceManager.HDInsight https://apiview.dev/Assemblies/Review/42888e1a3a694588b8f2c272a966f458
    Java azure-resourcemanager-hdinsightmicrosofthdinsighthdinsightonaks https://apiview.dev/Assemblies/Review/fb3083c74e474a2384e58ba48f31bdf4
    JavaScript @azure/arm-hdinsightcontainers https://apiview.dev/Assemblies/Review/3a4019e84a1945d59abe18a1a8f0a6ac

    This was referenced Aug 16, 2023
    Closed
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 16, 2023
    This was referenced Aug 16, 2023
    Closed
    Closed
    Closed
    Closed
    @MaryGao MaryGao mentioned this pull request Aug 23, 2023
    Closed
    @openapi-pipeline-app
    Copy link

    Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @weidongxu-microsoft
    Copy link
    Member

    Please resolve the conflict, so that dev can see the re-generated SDK.

    @msyyc
    Copy link
    Member

    msyyc commented Aug 23, 2023

    Python configuration has been updated in #25263

    @openapi-pipeline-app
    Copy link

    Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @openapi-pipeline-app
    Copy link

    Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @aim-for-better
    Copy link
    Member Author

    Please resolve the conflict, so that dev can see the re-generated SDK.

    Fixed, the #25263 is the final PR

    @aim-for-better aim-for-better requested a review from MaryGao August 23, 2023 06:37
    @aim-for-better
    Copy link
    Member Author

    Hi @weidongxu-microsoft do you know who can help review the nodejs readme file? Thanks

    @weidongxu-microsoft
    Copy link
    Member

    weidongxu-microsoft commented Aug 23, 2023 •
    edited
    Loading

    I don't know we need any nodejs readme.

    typescript follows readme.typescript.md

    @weidongxu-microsoft
    Copy link
    Member

    Good for Java.

    @aim-for-better
    Copy link
    Member Author

    Ok, thanks

    @ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 23, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 23, 2023
    @aim-for-better
    Copy link
    Member Author

    /pr RequestMerge

    @aim-for-better aim-for-better mentioned this pull request Aug 23, 2023
    Merged
    @ms-henglu ms-henglu merged commit 5372f41 into Azure:main Aug 23, 2023
    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    This was referenced Aug 23, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @aim-for-better
    Copy link
    Member Author

    Thanks @ms-henglu

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

    @ms-henglu ms-henglu ms-henglu approved these changes

    @msyyc msyyc Awaiting requested review from msyyc

    @tadelesh tadelesh Awaiting requested review from tadelesh

    @qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

    @MaryGao MaryGao Awaiting requested review from MaryGao

    Assignees

    @rkmanda rkmanda

    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @aim-for-better @weidongxu-microsoft @msyyc @MaryGao @ms-henglu @rkmanda @AzureRestAPISpecReview