[Hub Generated] Review request for Microsoft.HDInsight to add version preview/2023-04-15-preview #23743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @zeusone Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applications.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| applications.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| cluster.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| cluster.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| configurations.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| configurations.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| extensions.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| extensions.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| locations.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| locations.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| operations.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| operations.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| privateEndpointConnections.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| privateLinkResources.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| scriptActions.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| scriptActions.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
| virtualMachines.json | 2023-04-15-preview(4519fae) | 2021-06-01(main) |
| virtualMachines.json | 2023-04-15-preview(4519fae) | 2015-03-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 28 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2023-04 | package-preview-2023-04(4519fae) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json#L1199 |
The following errors/warnings exist before current PR submission:
Only 28 items are listed, please refer to log for more details.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/hdinsight/resource-manager/readme.md json: Microsoft.HDInsight/preview/2023-04-15-preview/scriptActions.json |
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: undefined, message: undefined" |
️❌~[Staging] ServiceAPIReadinessTest: 90 Errors, 0 Warnings failed [Detail]
Tag package-preview-2023-04; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 54, untested: 0, failed: 51, passed: 3
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 28 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 400, errorCode: NoRegisteredProviderFound, errorMessage: No registered resource provider found for location 'westcentralus' and API version '2023-04-15-preview' for type 'locations/checkNameAvailability'. The supported api-versions are '2015-03-01-preview, 2018-06-01-preview, 2021-06-01, 2023-04-15-preview'. The supported locations are 'eastasia, southeastasia, eastus, eastus2, westus, westus2, westus3, northcentralus, southcentralus, centralus, northeurope, westeurope, japaneast, japanwest, australiaeast, australiasoutheast, brazilsouth, centralindia, koreacentral, uksouth'. Source: runtime OperationId: Locations_CheckNameAvailability |
|
Additional properties not allowed: error Source: response OperationId: Locations_CheckNameAvailability |
|
statusCode: 400, errorCode: LocationRequired, errorMessage: The location property is required for this definition. Source: runtime OperationId: Clusters_Create |
|
Additional properties not allowed: error Source: response OperationId: Clusters_Create |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_Get |
|
Additional properties not allowed: error Source: response OperationId: Clusters_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_GetAzureAsyncOperationStatus |
|
Additional properties not allowed: error Source: response OperationId: Clusters_GetAzureAsyncOperationStatus |
|
statusCode: 404, errorCode: PatchResourceNotFound, errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-mhfMiO-23743/providers/Microsoft.HDInsight/clusters/clusternmxtpxl' was not found when evaluating policies for a PATCH operation. Source: runtime OperationId: Clusters_Update |
|
Additional properties not allowed: error Source: response OperationId: Clusters_Update |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_UpdateIdentityCertificate |
|
Additional properties not allowed: error Source: response OperationId: Clusters_UpdateIdentityCertificate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_UpdateGatewaySettings |
|
Additional properties not allowed: error Source: response OperationId: Clusters_UpdateGatewaySettings |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_GetGatewaySettings |
|
Additional properties not allowed: error Source: response OperationId: Clusters_GetGatewaySettings |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_ExecuteScriptActions |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Clusters_RotateDiskEncryptionKey |
|
Additional properties not allowed: error Source: response OperationId: Clusters_RotateDiskEncryptionKey |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternmxtpxl' not found. Source: runtime OperationId: Applications_Create |
|
Additional properties not allowed: error Source: response OperationId: Applications_Create |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternmxtpxl' not found. Source: runtime OperationId: Applications_ListByCluster |
|
Additional properties not allowed: error Source: response OperationId: Applications_ListByCluster |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternmxtpxl' not found. Source: runtime OperationId: Applications_Get |
|
Additional properties not allowed: error Source: response OperationId: Applications_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusternmxtpxl' not found. Source: runtime OperationId: Applications_GetAzureAsyncOperationStatus |
|
Additional properties not allowed: error Source: response OperationId: Applications_GetAzureAsyncOperationStatus |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HDInsight/clusters/clusternmxtpxl' under resource group 'apiTest-mhfMiO-23743' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrivateEndpointConnections_CreateOrUpdate |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
ghost
added
the
Swagger Generation Artifacts
|
Generated ApiView
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @zeusone your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
This was referenced Apr 27, 2023
This was referenced Apr 27, 2023
pilor
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
the
ReadyForApiTest
v-jiaodi
approved these changes
Apr 27, 2023
v-jiaodi
added
the
Approved-OkToMerge
openapi-workflow-bot
bot
added
commitAfterSignedOff
and removed
Approved-OkToMerge
|
Hi @zeusone, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This reverts commit 65b7c6c.
v-jiaodi
added
the
Approved-OkToMerge
chunyu3
deleted the
zeusone-hdinsight-Microsoft.HDInsight-2023-04-15-preview
branch
This was referenced May 4, 2023
[ReleasePR hdinsight] {HDInsight} Update hilo readme files
Azure/azure-resource-manager-schemas#2880
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.