Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release_2019_12_11_after_bump_version #1369

Merged
merged 1 commit into from
Dec 11, 2019
Merged

release_2019_12_11_after_bump_version #1369

merged 1 commit into from
Dec 11, 2019

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Dec 11, 2019 •
edited
Loading

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

danewalton-msft
danewalton-msft approved these changes Dec 11, 2019
View reviewed changes
iothub_client/tests/iothubclient_ll_u2b_ut/iothub_client_ll_u2b_ut.c
@@ -69,7 +69,7 @@ MOCKABLE_FUNCTION(, JSON_Object*, json_value_get_object, const JSON_Value *, val
#define TEST_STRING_HANDLE_DEVICE_SAS ((STRING_HANDLE)0x2)

#define TEST_API_VERSION "?api-version=2016-11-14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but should this be updated? this seems wildly out of date

hihigupt
hihigupt approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@hihigupt hihigupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ewertons ewertons merged commit 601e0cb into master Dec 11, 2019
@jbobotek
Copy link
Contributor

I know this is merged, but when do we version bump submodules like c-utility?

@ewertons ewertons deleted the release_2019_12_11 branch December 13, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hihigupt hihigupt hihigupt approved these changes

@danewalton-msft danewalton-msft danewalton-msft approved these changes

@gregman-msft gregman-msft gregman-msft approved these changes

@jasmineymlo jasmineymlo Awaiting requested review from jasmineymlo

@ericwolz ericwolz Awaiting requested review from ericwolz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewertons @jbobotek @hihigupt @danewalton-msft @gregman-msft @az-iot-builder-01