Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V3.x Branch with Latest Changes from Branch Dev #2958

Merged
merged 23 commits into from
Nov 13, 2024
Merged

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Nov 13, 2024

As titled. Routine PR to keep v3.x branch updated with dev.

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

bachuv and others added 23 commits August 29, 2023 16:07
Merge dev into main for v2.11.0 release
Merge dev to main for 2.11.2 release
Merge dev to main for 2.11.3 release
Merge dev into main for v2.11.4 release
Merge dev in to main for v2.12.0 release
Merge dev into main for v2.13.0 release
Merge dev into main for worker extension v1.1.0 release
Merge dev to main for v2.13.1 release
Merge Branch Dev To Branch Main
Merge Branch dev to Branch main
Merge main to dev, in preparation to merging dev to main
…#2929)

* initial commit

* add comment

* add test

* update by comment

* add httpmanagementpayload class

* re-arrange if section to make code more readable

* remove unnecessary exception catch

* add nullable check at HttpManagementPayload

* add nullable check

* Add comment as suggested

* Update FunctionsDurableTaskClientTests.cs

* update a typo as I found this at my e2e test
…rker. (#2732)

While the code does emit the warning and overwrites the option value, this is too late. The frameworks reads the "old" option value before the options are validated and actually runs as if the extended sessions are on. This leads to the hard-to-troubleshoot problems, e.g. the python worker never re-triggers the orchestration and never completes them.

PR also includes:
* details why mssql test fails
* `docker build --pull` to ensure the dockerfile is consistently built from the latest base images, no matter where it's built.
…ure.Functions.Worker.DurableTaskClientExtensions (#2875)

* Initial implementation of WaitForCompletionOrCreateCheckStatusResponseAsync

* Support X-Forwarded-Host et al

* Removed output of request headers used in my debugging

* Set location header to include returnInternalServerErrorOnFailure=true if requested

* update api and add unit test

* update sortings

* Remove unnecessary spaces

* add back forword request handling and update test accordingly

* update by comment

* add summary

* update test

* remove x-original-forwarded as we shouldn't use this

* default getinputsandoutputs to false

* update test by comment

---------

Co-authored-by: [email protected] <[email protected]>
@nytian nytian requested a review from bachuv November 13, 2024 01:51
@nytian nytian merged commit c9dcf15 into v3.x Nov 13, 2024
6 checks passed
@nytian nytian deleted the nytian/updatev3 branch November 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants