Rename the inner method name with _methodName
#2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
commented
Jan 10, 2025
| @@ -177,4 +177,8 @@ interface Budgets { | |||
| // the same name as Widgets.createOrReplace | |||
| @route("/widgets/createOrReplace") | |||
| op createOrReplace is ResourceOperations.LongRunningResourceCreateOrReplace<User>; | |||
|
|
|||
| @get getBudgets( | |||
There was a problem hiding this comment.
@jiaodi could you add this case into our UT?
MaryGao
requested review from
sarangan12,
joheredi and
qiaozha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2985
When building operation interfaces the method
get{Namespace}is only for inner usage and we should not export this method and it's better to add the underscore prefix to resolve pontential conflicts.