Solved issue 45: Add optional private endpoints for AI Services and Storage Accounts #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn the unique identifier of the created virtual network.
…cture for Blog Storage and File Shares.
…rt when the `use_private_endpoints` variable is set to `true`.
…Account services. This private endpoints are set when the variable `use_private_endpoints` is `true`. Also, the current IP address of the machine executing these templates is used as a allowed IP address to facilitate managing these services.
…ntly near 9 services requires them. - Increased the size of the subnet for the APIM as recommended by Microsoft's documentation. - Also, added delegation in the subnet for the APIM as specified by Microsoft's documentation.
…ge Account module.
…e_account_and_ai_services
rliberoff
requested review from
heblasco,
rag2111,
aniturza,
monicacalleja and
cmendible
as code owners
cmendible
requested changes
May 31, 2024
…ource in APIM module.
…alize all cognitive service configuration in the same module, especially for the private endpoints and DNS configurations.
Done. Changed as agreed! |
rliberoff
deleted the
45_add_optional_private_endpoints_for_storage_account_and_ai_services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would solve issue #45.
All private endpoints are set when the new variable
use_private_endpointsistrue. Also, the current IP address of the machine executing these templates is used as an allowed IP address to facilitate managing these services./29to/28since currently near 9 services requires them./27as recommended by Microsoft's documentation.Forms) module.use_private_endpointsvariable is set totrue.