Create empty blob if not exist. #35
Conversation
|
@NowinskiK sorry for the quick pull request. Found a bug in the incremental deployment. Sorry for the inconvenience. |
|
Related to #34 |
|
@LiquoriChris, can you make sure first you have the latest version of the code from |
|
@NowinskiK main now synced, tests updated, and updated changelog. |
|
Hi @LiquoriChris, could you please fix these small comments I left? |
|
Hey @NowinskiK, can you please re-check the code? I have updated when you mentioned in your first comment. Please let me know if I have missed anything. |
Hey @NowinskiK, sorry to bother. Can you please see comment above? |
|
There are some unexpected changes you introduced, like this one: |
|
Apologies. I removed the quotes in the original pr, but added them back in. Sorry about that. |
|
That's all right, but that was one of the reasons why it was with you. |
|
I do not think I can see comments in the files changed. It does not show any comments in the files changed tab. 
|
private/DeploymentState.class.ps1
Outdated
| } | ||
| Catch { | ||
| throw $_ | ||
| } |
There was a problem hiding this comment.
Why TRY in TRY? Can't be more elegant pls?
There was a problem hiding this comment.
Removed nested try/catch blocks.
|
ah... thanks! I should click "Request changes" then all my comments are moved here (see above). |
|
Hello @NowinskiK I have cleaned up the code (Thanks for that suggestion). I also updated the tests to make sure they pass. |
private/DeploymentState.class.ps1
Outdated
| } | ||
| Catch { | ||
| throw $_.Exception | ||
| } |
There was a problem hiding this comment.
Why catch an error and throw an exception? Why just do not remove the TRY/CATCH?
There was a problem hiding this comment.
@NowinskiK Please see updated code.
private/DeploymentState.class.ps1
Outdated
| catch { | ||
| Write-Verbose $_.Exception | ||
| Catch { | ||
| throw $_.Exception | ||
| } |
There was a problem hiding this comment.
@NowinskiK Please see updated code.
private/DeploymentState.class.ps1
Outdated
| } | ||
| catch { | ||
| Catch { | ||
| throw $_.Exception | ||
| } |
There was a problem hiding this comment.
@NowinskiK Please see updated code.
|
Hello @NowinskiK, I know it has been a while. Can you please see if this is still ok? I've updated the code per comments. |
|
But... there are still TRY/CATCH blocks. Example: DeploymentState.class.ps1 file. Why is that? |
|
I added try/catch just in case of failure... But I can remove entirely. |
|
My point is that it does nothing. You catch potential error and rethrow it. I can't see the logic. |
|
I see your point. Removed. |
No description provided.