Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Disk Analyser Config from the AWS Connector #239

Conversation

blichev
Copy link
Contributor

@blichev blichev commented Jan 8, 2025

This PR removes Disk Analyser Config from the AWS Connector. This is due to changes in wiz api where this attribute is not present anymore.

closes #238
related to #236

Acceptance Test

=== RUN   TestAccResourceWizConnectorAws_basic
2025/01/09 09:55:22 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:23 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:23 [DEBUG] POST https://api.eu4.app.wiz.io/graphql
2025/01/09 09:55:24 [DEBUG] POST https://api.eu4.app.wiz.io/graphql
2025/01/09 09:55:24 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:25 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:25 [DEBUG] POST https://api.eu4.app.wiz.io/graphql
2025/01/09 09:55:25 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:26 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/09 09:55:26 [DEBUG] POST https://api.eu4.app.wiz.io/graphql
--- PASS: TestAccResourceWizConnectorAws_basic (7.08s)
PASS
ok  	wiz.io/hashicorp/terraform-provider-wiz/internal/acceptance	10.447s

This PR removes Disk Analyser Config from the AWS Connector. This is due to changes in wiz api where this attribute is not present anymore.

closes AxtonGrams#238
related to AxtonGrams#236
@blichev blichev requested a review from a team as a code owner January 8, 2025 17:14
@jschoombee
Copy link
Collaborator

Thanks for contribution!

PR looks good to merge, if you would please run the acc tests as per contribution guide and attach the output to the PR, following which this can be released

@blichev
Copy link
Contributor Author

blichev commented Jan 8, 2025

Hello @jschoombee, thank you for looking into the issue and your guidance!

As far as I can understand running the acceptance tests requires providing Wiz Credentials and unfortunately I don't have a test environment for it.

@jschoombee
Copy link
Collaborator

Hello @jschoombee, thank you for looking into the issue and your guidance!

As far as I can understand running the acceptance tests requires providing Wiz Credentials and unfortunately I don't have a test environment for it.

I ran the test and updated the PR on your behalf. Thanks for the fix

@jschoombee jschoombee changed the title Remove Disk Analyser Config from the AWS Connector Fix: Remove Disk Analyser Config from the AWS Connector Jan 9, 2025
@jschoombee jschoombee merged commit b89bd9f into AxtonGrams:main Jan 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Connector apply fails during post-creation read
2 participants