Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds new service account types. closes #193 #222

Merged
merged 2 commits into from
Sep 4, 2024
Merged

adds new service account types. closes #193 #222

merged 2 commits into from
Sep 4, 2024

Conversation

mjuarez
Copy link
Contributor

@mjuarez mjuarez commented Sep 3, 2024 •
edited by jschoombee
Loading

Adds new service account types
closes #193

@mjuarez mjuarez requested a review from a team as a code owner September 3, 2024 16:09
@jschoombee
Copy link
Collaborator

Thanks for contribution

@jschoombee jschoombee merged commit 854a1be into AxtonGrams:main Sep 4, 2024
6 of 7 checks passed
@mjuarez mjuarez deleted the mjuarez/new-svc-acct-types branch September 4, 2024 16:19
@mjuarez
Copy link
Contributor Author

mjuarez commented Sep 4, 2024

@jschoombee What is the release cycle/process? When can I pull this change from registry?

@jschoombee
Copy link
Collaborator

@jschoombee What is the release cycle/process? When can I pull this change from registry?

If I can get through the housekeeping this evening, will get it released same time. Normally, once the tag is created it takes a few hours to become available in the registry.

@jschoombee
Copy link
Collaborator

@jschoombee What is the release cycle/process? When can I pull this change from registry?

If I can get through the housekeeping this evening, will get it released same time. Normally, once the tag is created it takes a few hours to become available in the registry.

The go releaser update had a breaking change. There is an open PR #223 to fix. As Axton is away, I can't merge my own PRs. Easiest would be for you to review and submit the same fix for goreleaser and then we can get this released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschoombee jschoombee jschoombee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update serviceAccount types to include the Complete Kubernetes Integration and Kubernetes Connector
2 participants
@mjuarez @jschoombee