Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aria-disabled button state #465

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix aria-disabled button state #465

merged 1 commit into from
Nov 28, 2024

Conversation

djalmaaraujo
Copy link
Contributor

Description

Fixes a regression from 2.11.0 where all submit buttons were getting aria-disabled by default.

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. http://localhost:6006/?path=/story/button--prefer-aria-disabled
  4. Confirm aria-disabled is applied
  5. Open http://localhost:6006/?path=/story/buttonsubmit--primary
  6. Confirm aria-disabled is not applied as true

@djalmaaraujo djalmaaraujo requested review from luismulinari and a team November 28, 2024 13:07
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 5d24b88
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/67486aff0ecda30008dda0d1
😎 Deploy Preview https://deploy-preview-465--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo merged commit 59304a9 into trunk Nov 28, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the fix-button-submit branch November 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismulinari luismulinari luismulinari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djalmaaraujo @luismulinari