Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to resolve issues #2 #3 #4. #7

Merged
merged 3 commits into from
Oct 2, 2015
Merged

Attempt to resolve issues #2 #3 #4. #7

merged 3 commits into from
Oct 2, 2015

Conversation

southp
Copy link
Contributor

@southp southp commented Aug 16, 2015

Resolving Issue #2: 2e401b9

Cache the return value of strtoupper( $country_name ) outside the loop.

Resolving Issue #3: 54f988e

Cache the return value as $usa_entry to make the attempt of default usage self-explanatory.

Resolving Issue #4: dbb640a

Mark Iso3166::$data as private, and access it through the public function: get_data() instead.

southp added 3 commits August 17, 2015 05:55
@southp
Cache the return value of strtouppser( $country_name ) outside the loop
2e401b9 
as $country_name_upper, so it is not called for every iteration.

This closes #2.
@southp
Mark Iso3166::$data as private, and access it through a public getter
dbb640a 
function: get_data() instead.

This closes issue #4.
@southp
The code that get_iso3166_entry() will return USA entry if no
54f988e 
$country_name is given is too vague. Make it self-explanatory by cache
the value first.

This closes issue #3.
@mjangda
Copy link
Member

mjangda commented Oct 2, 2015

👍

southp added a commit that referenced this pull request Oct 2, 2015
@southp
Merge pull request #7 from Automattic/fix/issue-2-3-4
3aec6da 
Attempt to resolve issues #2 #3 #4.
@southp southp merged commit 3aec6da into master Oct 2, 2015
@southp southp deleted the fix/issue-2-3-4 branch October 2, 2015 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@southp @mjangda