Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iso3166::$data is public #4

Open
mjangda opened this issue Aug 14, 2015 · 0 comments
Open

Iso3166::$data is public #4

mjangda opened this issue Aug 14, 2015 · 0 comments

Comments

@mjangda
Copy link
Member

mjangda commented Aug 14, 2015

Might be better as a private var that's accessible via a get* method.
southp added a commit that referenced this issue Aug 16, 2015
@southp
Mark Iso3166::$data as private, and access it through a public getter
dbb640a 
function: get_data() instead.

This closes issue #4.
@southp southp mentioned this issue Aug 16, 2015
Merged
southp added a commit that referenced this issue Oct 2, 2015
@southp
Merge pull request #7 from Automattic/fix/issue-2-3-4
3aec6da 
Attempt to resolve issues #2 #3 #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjangda