Replace fetch api #2309

YuMuuu · 2023-11-27T15:23:57Z

Use fetch api and remove simple-get depedency (context: #2223 (comment)).

Have you updated CHANGELOG.md?

YuMuuu · 2023-11-27T16:12:53Z

I will make sure that the relevant PR is made 👀
I rebase if necessary or split PR.

zbjornson · 2023-11-27T21:04:12Z

Thanks, that's a nice change. #2310 will need to land first to drop support for older versions of Node.js.

YuMuuu · 2023-11-28T01:15:11Z

Thanks, that's a nice change. #2310 will need to land first to drop support for older versions of Node.js.

Ok. I can rebaes after merged #2310

YuMuuu · 2023-11-28T01:22:31Z

c0725b8

This commit is important, Should I separate PR?

LinusU · 2023-11-28T13:28:31Z

lib/image.js

-
-        get.concat({
-          url: val,
+        const request =  fetch(url = val, data = {


This creates two new global variables, url and data. I'm guessing it was a misstake

Suggested change

const request = fetch(url = val, data = {

const request = fetch(val, {

LinusU · 2023-11-28T13:28:50Z

lib/image.js

-        get.concat({
-          url: val,
+        const request =  fetch(url = val, data = {
+          method: "POST",


Can you use single quotes to align with the rest of the file?

Suggested change

method: "POST",

method: 'POST',

LinusU · 2023-11-28T13:29:49Z

lib/image.js

+        })

+        request.then((res) => {


Since request is only used once, you could chain here and remove the variable:

Suggested change

})

request.then((res) => {

})

.then((res) => {

LinusU · 2023-11-28T13:30:11Z

lib/image.js

+          return res.arrayBuffer()
+        })
+        .then((data) => {
+          return setSource(this, data)


setSource doesn't return anything?

Suggested change

return setSource(this, data)

setSource(this, data)

LinusU · 2023-11-28T13:34:17Z

lib/image.js

+          return setSource(this, data)
+        })
+        .catch((err) => {
+          return onerror(err)


Same here.

Suggested change

return onerror(err)

onerror(err)

Also, the behaviour of onerror is that it throws if a handler hasn't been set. Before this change, that thrown was delegated to the global error handler.

Now it will instead be eaten by this promise, which I don't think is desirable.

I think that util.callbackify or process.nextTick would be best used to restore the old behaviour 🤔

=> 93cfd2f

I'm not sure if the changes I made are correct...

LinusU · 2023-11-29T09:54:22Z

@YuMuuu could you rebase on latest master? I've merged #2310 and #2313 which are alternative ways of dealing with the problems you had with dtslint and minimum version of Node...

YuMuuu · 2023-11-29T18:39:05Z

rebase master and drop unnecessary commit

YuMuuu · 2023-11-29T18:44:13Z

lib/image.js

+        util
+        .callbackify(
+          fetch(val, {
+            method: 'POST',


I'm not sure if the changes I made are correct.

simple-get.concat method type is GET.

YuMuuu · 2023-12-03T22:40:58Z

@LinusU I fixed it

YuMuuu · 2023-12-06T09:28:38Z

@LinusU This is just a reminder if you missed my commit. Could you please take a look at my commits I’ve done last week and merge it if it looks ok.

YuMuuu · 2024-04-30T07:51:58Z

@LinusU Could you please review this PR? ;;

YuMuuu · 2024-05-24T12:35:19Z

@zbjornson Could you review, as it seems that @LinusU is busy?

kunipon · 2024-09-11T14:28:11Z

@LinusU Could you please let me know when the pull request is expected to be merged?

LinusU · 2024-09-11T18:46:02Z

Sorry for being a bit slow on the feedback here...

Looking at the code, I don't think that it works? Have you tested this?

YuMuuu · 2024-11-27T00:56:37Z

We have not been able to check all the test cases that are not on CI. What kind of test cases do you think are not working?

chearon · 2025-01-11T16:39:37Z

I squashed the commits and removed require('node-fetch'), which I couldn't justify. Also spent a while thinking about @LinusU's comment but I'm pretty sure it doesn't apply to the current diff. Throwing in a catch handler still goes to that nodejs event. Though it does get scheduled differently than before, I don't think that should be considered a breaking change.

YuMuuu · 2025-01-28T03:09:22Z

Thank you very much for reviewing, merging and releasing it!
I'm grateful for the node-cavas and contributors.

YuMuuu changed the title ~~Use fetch api~~ Replace fetch api Nov 27, 2023

LinusU reviewed Nov 28, 2023

View reviewed changes

LinusU mentioned this pull request Nov 29, 2023

🚢 3.0.0 planning issue #2232

Closed

8 tasks

YuMuuu force-pushed the use-fetch-api branch from 51ba305 to 93cfd2f Compare November 29, 2023 18:36

YuMuuu commented Nov 29, 2023

View reviewed changes

YuMuuu force-pushed the use-fetch-api branch 2 times, most recently from 5213c1f to a2e3845 Compare November 29, 2023 19:01

YuMuuu requested a review from LinusU December 14, 2023 08:11

zbjornson force-pushed the master branch 2 times, most recently from 64ed3d8 to ff0f2ab Compare December 28, 2023 23:22

YuMuuu force-pushed the use-fetch-api branch from a2e3845 to 6f690c1 Compare January 1, 2024 15:46

use fetch api

c0785c5

chearon force-pushed the use-fetch-api branch from 62032a0 to c0785c5 Compare January 11, 2025 16:34

chearon approved these changes Jan 11, 2025

View reviewed changes

chearon merged commit 1d956b7 into Automattic:master Jan 11, 2025

YuMuuu deleted the use-fetch-api branch January 28, 2025 03:09

YuMuuu restored the use-fetch-api branch January 29, 2025 03:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace fetch api #2309

Replace fetch api #2309

YuMuuu commented Nov 27, 2023 •

edited

Loading

YuMuuu commented Nov 27, 2023 •

edited

Loading

zbjornson commented Nov 27, 2023

YuMuuu commented Nov 28, 2023 •

edited

Loading

YuMuuu commented Nov 28, 2023

LinusU Nov 28, 2023

LinusU Nov 28, 2023

LinusU Nov 28, 2023

LinusU Nov 28, 2023

LinusU Nov 28, 2023

YuMuuu Nov 29, 2023

LinusU commented Nov 29, 2023

YuMuuu commented Nov 29, 2023 •

edited

Loading

YuMuuu Nov 29, 2023

YuMuuu commented Dec 3, 2023 •

edited

Loading

YuMuuu commented Dec 6, 2023

YuMuuu commented Apr 30, 2024

YuMuuu commented May 24, 2024

kunipon commented Sep 11, 2024

LinusU commented Sep 11, 2024

YuMuuu commented Nov 27, 2024

chearon commented Jan 11, 2025

YuMuuu commented Jan 28, 2025 •

edited

Loading

	const request = fetch(url = val, data = {
	const request = fetch(val, {

Replace fetch api #2309

Replace fetch api #2309

Conversation

YuMuuu commented Nov 27, 2023 • edited Loading

YuMuuu commented Nov 27, 2023 • edited Loading

zbjornson commented Nov 27, 2023

YuMuuu commented Nov 28, 2023 • edited Loading

YuMuuu commented Nov 28, 2023

LinusU Nov 28, 2023

Choose a reason for hiding this comment

LinusU Nov 28, 2023

Choose a reason for hiding this comment

LinusU Nov 28, 2023

Choose a reason for hiding this comment

LinusU Nov 28, 2023

Choose a reason for hiding this comment

LinusU Nov 28, 2023

Choose a reason for hiding this comment

YuMuuu Nov 29, 2023

Choose a reason for hiding this comment

LinusU commented Nov 29, 2023

YuMuuu commented Nov 29, 2023 • edited Loading

YuMuuu Nov 29, 2023

Choose a reason for hiding this comment

YuMuuu commented Dec 3, 2023 • edited Loading

YuMuuu commented Dec 6, 2023

YuMuuu commented Apr 30, 2024

YuMuuu commented May 24, 2024

kunipon commented Sep 11, 2024

LinusU commented Sep 11, 2024

YuMuuu commented Nov 27, 2024

chearon commented Jan 11, 2025

YuMuuu commented Jan 28, 2025 • edited Loading

YuMuuu commented Nov 27, 2023 •

edited

Loading

YuMuuu commented Nov 27, 2023 •

edited

Loading

YuMuuu commented Nov 28, 2023 •

edited

Loading

YuMuuu commented Nov 29, 2023 •

edited

Loading

YuMuuu commented Dec 3, 2023 •

edited

Loading

YuMuuu commented Jan 28, 2025 •

edited

Loading