Protected surfaces #1539
Open
Protected surfaces #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be reviewed and merged? |
|
Code sync'ed with latest |
|
Can this be reviewed and merged? |
LinusU
reviewed
Jan 18, 2022
| @@ -914,8 +914,6 @@ Canvas::resurface(Local<Object> canvas) { | |||
| Nan::HandleScope scope; | |||
| Local<Value> context; | |||
|
|
|||
| backend()->recreateSurface(); | |||
There was a problem hiding this comment.
Would you mind explaining this change? I'm not to familiar with this part of the code 😅
There was a problem hiding this comment.
I don't remember the exact details, but reviewing the PR, seems to me like a bug, because recreateSurface() it's not being called anywhere else...
There was a problem hiding this comment.
Maybe best to add it back?
There was a problem hiding this comment.
Maybe, or test it first as is, to be sure if it crash or fails.
LinusU
reviewed
Jan 18, 2022
Thank you! :-) |
zbjornson
force-pushed
the
master
branch
2 times, most recently
from
64ed3d8 to
ff0f2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstract and protect the actual Cairo surfaces, making them an implementation detail of the backends, preventing to be created or destroyed from outside. This allow for greater isolation of concepts, allowing to access to the actual Cairo surface just only by using the
getSurface()method, preventing any other direct access.