-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy/blaze quick links disappearing after quick edit #41339
Conversation
After using quick edit to save a change the Copy quick action is no longer displayed. It works on posts but not on other CPTs, including pages. This change allows the Copy quick action on all CPTs. Related: Automattic/wp-calypso#97995
After using quick edit to save a change the Blaze quick action was no longer displayed. It works on posts but not on other CPTs, including pages. This change allows the Share with Blaze on all blaze-eligible CPTs after a quick-edit. Note that Blaze is only designed for posts, pages and products at present, nothing in this PR changes that. Related: Automattic/wp-calypso#97995
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Fixes Automattic/wp-calypso#97995
This is a follow-up to #40889 which only worked on the posts post type.
Proposed changes:
The page list has a number of quick links including 'Promote with Blaze', 'Copy' and Quick Edit. After using Quick Edit, the Blaze and Copy links go missing - they're not registered when the ajax response includes the new quick links.
This is solved by adjust the post_row_actions registration logic on the admin-ajax.php page to work for all post types as well as the edit.php page.
The Blaze functionality is only available on Page, Post & Product post types. This does not change that.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: