Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy/blaze quick links disappearing after quick edit #41339

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Jan 27, 2025

Fixes Automattic/wp-calypso#97995
This is a follow-up to #40889 which only worked on the posts post type.

Proposed changes:

The page list has a number of quick links including 'Promote with Blaze', 'Copy' and Quick Edit. After using Quick Edit, the Blaze and Copy links go missing - they're not registered when the ajax response includes the new quick links.

This is solved by adjust the post_row_actions registration logic on the admin-ajax.php page to work for all post types as well as the edit.php page.

The Blaze functionality is only available on Page, Post & Product post types. This does not change that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Apply the patch to your wpcom sandbox following the instructions in the comment below
  2. Sandbox your site
  3. Go to /wp-admin/edit.php?post_type=page
  4. You should see that your pages have various quick links including 'Copy' and 'Promote with Blaze'
  5. Press 'Quick Edit' and make a simple change, e.g. toggling comments
  6. Press the 'Update' button
  7. Look at the quick links again, you should see that 'Copy' and 'Promote with Blaze' are still there.

dsas added 3 commits January 27, 2025 16:14
After using quick edit to save a change the Copy quick action is no
longer displayed. It works on posts but not on other CPTs, including
pages.

This change allows the Copy quick action on all CPTs.

Related: Automattic/wp-calypso#97995
After using quick edit to save a change the Blaze quick action was no
longer displayed. It works on posts but not on other CPTs, including
pages.

This change allows the Share with Blaze on all blaze-eligible CPTs
after a quick-edit.

Note that Blaze is only designed for posts, pages and products at
present, nothing in this PR changes that.

Related: Automattic/wp-calypso#97995
@dsas dsas self-assigned this Jan 27, 2025
@github-actions github-actions bot added [Package] Blaze [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on February 4, 2025).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/quickedit-copy-cpt branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/quickedit-copy-cpt
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/quickedit-copy-cpt
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@dsas dsas added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 27, 2025
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Jan 27, 2025
@kraftbj kraftbj merged commit 13838d9 into trunk Jan 28, 2025
64 checks passed
@kraftbj kraftbj deleted the fix/quickedit-copy-cpt branch January 28, 2025 17:52
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 28, 2025
@github-actions github-actions bot added this to the jetpack/14.3 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Blaze [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post quick links change after saving a quick edit
3 participants