Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-2111 print collection membership #4100

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

pierrebai-adsk
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk commented Jan 31, 2025

  • Add a printCollection function to the CollectionData class.
  • Implement this function in the UsdCollectionData class.
  • Print the collection by calling computeMembership and printing the result.
  • Add a menu item to print the collection.

Work around a bug in USD: when both a membership expression and explicit
inclusions or exclusions are used, we need to call a different less
efficient USD function to compute the membership because the simpler,
faster function is not working correctly.

@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-2111/print-prims branch from 38d7a43 to 6a3086d Compare January 31, 2025 14:18
@pierrebai-adsk pierrebai-adsk self-assigned this Jan 31, 2025
- Add a printCollection function to the CollectionData class.
- Implement this function in the UsdCollectionData class.
- Print the collection by calling computeMembership and printing the result.
- Add a menu item to print the collection.

Work around a bug in USD: when both a membership expression and explicit
inclusions or exclusions are used, we need to call a different less
efficient USD function to compute the membership because the simpler,
faster function is not working correctly.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-2111/print-prims branch from 6a3086d to 55a16a3 Compare January 31, 2025 18:51
@pierrebai-adsk pierrebai-adsk removed their assignment Jan 31, 2025
@pierrebai-adsk pierrebai-adsk added the shared_components Shared Components (Max / Maya) label Jan 31, 2025
@pierrebai-adsk pierrebai-adsk self-assigned this Jan 31, 2025
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 3, 2025
@seando-adsk seando-adsk merged commit fd282fc into dev Feb 4, 2025
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-2111/print-prims branch February 4, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge shared_components Shared Components (Max / Maya)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants